Re: [PATCH V6 08/10] [SCSI] aacraid: Send commit-config to controller firmware

[Tomas Henzl <thenzl@redhat.com>]

On 11.8.2015 07:58, Mahesh Rajashekhara wrote:
> Description:
> 	Controller BIOS/UEFI driver used to send this request.  But for
> 	IBM-Power system there is no BIOS/UEFI driver.  So this change is
> 	required for IBM, otherwise controller will be read-only mode.
>
> Changes from V2:
> None
>
> Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>
> ---
>  drivers/scsi/aacraid/linit.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
> index 3b6e5c6..35dd849 100644
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -1270,8 +1270,11 @@ static int aac_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
>  		shost->max_channel = aac->maximum_num_channels;
>  	else
>  		shost->max_channel = 0;
> -
> +#if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__)
> +	aac_get_config_status(aac, 1);
> +#else
>  	aac_get_config_status(aac, 0);
> +#endif

If we use instead
+	aac_get_config_status(aac, 1);
on all archs will it make problems ?

Tomas

>  	aac_get_containers(aac);
>  	list_add(&aac->entry, insert);
>