From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [PATCH V6 08/10] [SCSI] aacraid: Send commit-config to controller firmware Date: Tue, 25 Aug 2015 16:57:26 +0200 Message-ID: <55DC8256.4060102@redhat.com> References: <1439272701-15344-1-git-send-email-Mahesh.Rajashekhara@pmcs.com> <1439272701-15344-9-git-send-email-Mahesh.Rajashekhara@pmcs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47018 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753943AbbHYO53 (ORCPT ); Tue, 25 Aug 2015 10:57:29 -0400 In-Reply-To: <1439272701-15344-9-git-send-email-Mahesh.Rajashekhara@pmcs.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Mahesh Rajashekhara , JBottomley@Parallels.com, linux-scsi@vger.kernel.org Cc: aacraid@pmc-sierra.com, Harry.Yang@pmcs.com, Rich.Bono@pmcs.com On 11.8.2015 07:58, Mahesh Rajashekhara wrote: > Description: > Controller BIOS/UEFI driver used to send this request. But for > IBM-Power system there is no BIOS/UEFI driver. So this change is > required for IBM, otherwise controller will be read-only mode. > > Changes from V2: > None > > Signed-off-by: Mahesh Rajashekhara > --- > drivers/scsi/aacraid/linit.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c > index 3b6e5c6..35dd849 100644 > --- a/drivers/scsi/aacraid/linit.c > +++ b/drivers/scsi/aacraid/linit.c > @@ -1270,8 +1270,11 @@ static int aac_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) > shost->max_channel = aac->maximum_num_channels; > else > shost->max_channel = 0; > - > +#if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__) > + aac_get_config_status(aac, 1); > +#else > aac_get_config_status(aac, 0); > +#endif If we use instead + aac_get_config_status(aac, 1); on all archs will it make problems ? Tomas > aac_get_containers(aac); > list_add(&aac->entry, insert); >