From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h Date: Wed, 16 Sep 2015 16:31:07 +0200 Message-ID: <55F97D2B.3000404@redhat.com> References: <1442308888-17911-1-git-send-email-pbonzini@redhat.com> <20150916133926.GA9658@lst.de> <55F97992.6050905@redhat.com> <20150916142340.GA11338@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51900 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbbIPObL (ORCPT ); Wed, 16 Sep 2015 10:31:11 -0400 In-Reply-To: <20150916142340.GA11338@lst.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig Cc: houcheng@gmail.com, Andy Grover , James Bottomley , Douglas Gilbert , Linux SCSI List On 16/09/2015 16:23, Christoph Hellwig wrote: > > I'm trying to cater to the objections that were made to Andy's patch. > > If you mean the non-UAPI headers, James wanted them to stay in scsi/; if > > you mean the UAPI headers, Douglas complained about the flat structure > > of include/linux/. > > Yes, keep the non-UAPI ones as is and move the UAPI ones to linux/ - the flat > structure is a feature, not a bug. > > > > Also scsi/scsi.h has some additional ioctl defintions that should be > > > added to the UAPI scsi_ioctl.h. Otherwise this looks ok to me. > > > > I can do this, but I think they are obsoleted by SG_GET_SCSI_ID, except > > for SCSI_IOCTL_GET_PCI which is horrible anyway. :) The comment about > > conflicts with CDROM ioctls is also interesting. I can see why one > > would want to keep them out of the new canonical place for SCSI ioctls. > > No point in hiding them. We can still officially deprecate them, but I'd > much rather have them in a single place than hidden away somewhere. Ok, will do both. Paolo