From: Khalid Aziz <khalid@gonehiking.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"James E.J. Bottomley" <JBottomley@odin.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] FlashPoint: fix build warning
Date: Wed, 16 Sep 2015 08:47:43 -0600 [thread overview]
Message-ID: <55F9810F.6030004@gonehiking.org> (raw)
In-Reply-To: <1442412380-1832-1-git-send-email-sudipm.mukherjee@gmail.com>
On 09/16/2015 08:06 AM, Sudip Mukherjee wrote:
> We have been getting a warning about non ANSI function.
> warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/scsi/FlashPoint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
> index 5c74e4c..867b864 100644
> --- a/drivers/scsi/FlashPoint.c
> +++ b/drivers/scsi/FlashPoint.c
> @@ -2136,7 +2136,7 @@ static unsigned char FPT_SccbMgr_bad_isr(u32 p_port, unsigned char p_card,
> *
> *---------------------------------------------------------------------*/
>
> -static void FPT_SccbMgrTableInitAll()
> +static void FPT_SccbMgrTableInitAll(void)
> {
> unsigned char thisCard;
>
>
Acked-by: Khalid Aziz <khalid@gonehiking.org>
James, please apply this to your SCSI tree.
--
Khalid
next prev parent reply other threads:[~2015-09-16 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 14:06 [PATCH] [SCSI] FlashPoint: fix build warning Sudip Mukherjee
2015-09-16 14:47 ` Khalid Aziz [this message]
2015-10-02 8:01 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F9810F.6030004@gonehiking.org \
--to=khalid@gonehiking.org \
--cc=JBottomley@odin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox