* [PATCH RESEND] scsi: Fix sense information setting in fixed sized format
@ 2015-09-03 16:49 Sagi Grimberg
2015-09-03 19:02 ` Ewan Milne
0 siblings, 1 reply; 5+ messages in thread
From: Sagi Grimberg @ 2015-09-03 16:49 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi
In fixed size sense format the information field is a four byte
field.
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
drivers/scsi/scsi_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c
index 41432c10dda2..8cfb7eeb5bbc 100644
--- a/drivers/scsi/scsi_common.c
+++ b/drivers/scsi/scsi_common.c
@@ -270,7 +270,7 @@ void scsi_set_sense_information(u8 *buf, u64 info)
put_unaligned_be64(info, &ucp[4]);
} else if ((buf[0] & 0x7f) == 0x70) {
buf[0] |= 0x80;
- put_unaligned_be64(info, &buf[3]);
+ put_unaligned_be32(info, &buf[3]);
}
}
EXPORT_SYMBOL(scsi_set_sense_information);
--
1.8.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] scsi: Fix sense information setting in fixed sized format
2015-09-03 16:49 [PATCH RESEND] scsi: Fix sense information setting in fixed sized format Sagi Grimberg
@ 2015-09-03 19:02 ` Ewan Milne
2015-09-17 12:42 ` Sagi Grimberg
0 siblings, 1 reply; 5+ messages in thread
From: Ewan Milne @ 2015-09-03 19:02 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: James Bottomley, linux-scsi
On Thu, 2015-09-03 at 19:49 +0300, Sagi Grimberg wrote:
> In fixed size sense format the information field is a four byte
> field.
>
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/scsi/scsi_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c
> index 41432c10dda2..8cfb7eeb5bbc 100644
> --- a/drivers/scsi/scsi_common.c
> +++ b/drivers/scsi/scsi_common.c
> @@ -270,7 +270,7 @@ void scsi_set_sense_information(u8 *buf, u64 info)
> put_unaligned_be64(info, &ucp[4]);
> } else if ((buf[0] & 0x7f) == 0x70) {
> buf[0] |= 0x80;
> - put_unaligned_be64(info, &buf[3]);
> + put_unaligned_be32(info, &buf[3]);
> }
> }
> EXPORT_SYMBOL(scsi_set_sense_information);
Looks correct per SPC-4 4.5.3
And you did post a patch to target for the case where the sector
did not fit in 32 bits, which requires descriptor format sense, so...
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] scsi: Fix sense information setting in fixed sized format
2015-09-03 19:02 ` Ewan Milne
@ 2015-09-17 12:42 ` Sagi Grimberg
2015-09-17 14:24 ` James Bottomley
0 siblings, 1 reply; 5+ messages in thread
From: Sagi Grimberg @ 2015-09-17 12:42 UTC (permalink / raw)
To: James Bottomley; +Cc: emilne, linux-scsi
On 9/3/2015 10:02 PM, Ewan Milne wrote:
> On Thu, 2015-09-03 at 19:49 +0300, Sagi Grimberg wrote:
>> In fixed size sense format the information field is a four byte
>> field.
>>
>> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
>> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> ---
>> drivers/scsi/scsi_common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c
>> index 41432c10dda2..8cfb7eeb5bbc 100644
>> --- a/drivers/scsi/scsi_common.c
>> +++ b/drivers/scsi/scsi_common.c
>> @@ -270,7 +270,7 @@ void scsi_set_sense_information(u8 *buf, u64 info)
>> put_unaligned_be64(info, &ucp[4]);
>> } else if ((buf[0] & 0x7f) == 0x70) {
>> buf[0] |= 0x80;
>> - put_unaligned_be64(info, &buf[3]);
>> + put_unaligned_be32(info, &buf[3]);
>> }
>> }
>> EXPORT_SYMBOL(scsi_set_sense_information);
>
> Looks correct per SPC-4 4.5.3
>
> And you did post a patch to target for the case where the sector
> did not fit in 32 bits, which requires descriptor format sense, so...
>
> Reviewed-by: Ewan D. Milne <emilne@redhat.com>
James, can you pick this up please?
Thanks,
Sagi.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] scsi: Fix sense information setting in fixed sized format
2015-09-17 12:42 ` Sagi Grimberg
@ 2015-09-17 14:24 ` James Bottomley
2015-09-17 16:47 ` Sagi Grimberg
0 siblings, 1 reply; 5+ messages in thread
From: James Bottomley @ 2015-09-17 14:24 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: emilne, linux-scsi
On Thu, 2015-09-17 at 15:42 +0300, Sagi Grimberg wrote:
> On 9/3/2015 10:02 PM, Ewan Milne wrote:
> > On Thu, 2015-09-03 at 19:49 +0300, Sagi Grimberg wrote:
> >> In fixed size sense format the information field is a four byte
> >> field.
> >>
> >> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> >> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> >> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
> >> Reviewed-by: Christoph Hellwig <hch@lst.de>
> >> ---
> >> drivers/scsi/scsi_common.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/scsi/scsi_common.c b/drivers/scsi/scsi_common.c
> >> index 41432c10dda2..8cfb7eeb5bbc 100644
> >> --- a/drivers/scsi/scsi_common.c
> >> +++ b/drivers/scsi/scsi_common.c
> >> @@ -270,7 +270,7 @@ void scsi_set_sense_information(u8 *buf, u64 info)
> >> put_unaligned_be64(info, &ucp[4]);
> >> } else if ((buf[0] & 0x7f) == 0x70) {
> >> buf[0] |= 0x80;
> >> - put_unaligned_be64(info, &buf[3]);
> >> + put_unaligned_be32(info, &buf[3]);
> >> }
> >> }
> >> EXPORT_SYMBOL(scsi_set_sense_information);
> >
> > Looks correct per SPC-4 4.5.3
> >
> > And you did post a patch to target for the case where the sector
> > did not fit in 32 bits, which requires descriptor format sense, so...
> >
> > Reviewed-by: Ewan D. Milne <emilne@redhat.com>
>
> James, can you pick this up please?
It went quietly via the target tree. I did keep an eye on it because
the target disruption in scsi_sommon.c was why I couldn't send the rest
of your sense descriptor patches via scsi.
commit 12306b425d0dbab7b60f54e02d67cf3dfae494d1
James
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] scsi: Fix sense information setting in fixed sized format
2015-09-17 14:24 ` James Bottomley
@ 2015-09-17 16:47 ` Sagi Grimberg
0 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2015-09-17 16:47 UTC (permalink / raw)
To: James Bottomley; +Cc: emilne, linux-scsi
>> James, can you pick this up please?
>
> It went quietly via the target tree. I did keep an eye on it because
> the target disruption in scsi_sommon.c was why I couldn't send the rest
> of your sense descriptor patches via scsi.
>
> commit 12306b425d0dbab7b60f54e02d67cf3dfae494d1
I didn't notice that. Sorry for the hassle.
Thanks James!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-17 16:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-03 16:49 [PATCH RESEND] scsi: Fix sense information setting in fixed sized format Sagi Grimberg
2015-09-03 19:02 ` Ewan Milne
2015-09-17 12:42 ` Sagi Grimberg
2015-09-17 14:24 ` James Bottomley
2015-09-17 16:47 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox