From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 4/4] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h
Date: Thu, 17 Sep 2015 08:32:15 -0700 [thread overview]
Message-ID: <55FADCFF.5000104@sandisk.com> (raw)
In-Reply-To: <1442497647-17778-1-git-send-email-pbonzini@redhat.com>
On 09/17/2015 06:47 AM, Paolo Bonzini wrote:
> +
> +#ifndef __KERNEL__
> +/* Keep in sync with SG_DEFAULT_TIMEOUT of scsi/sg.h */
> #define SG_DEFAULT_TIMEOUT (60*HZ) /* HZ == 'jiffies in 1 second' */
> #endif
Is it useful and/or necessary to export this constant ? To me this
looks like an implementation aspect rather than an aspect of the scsi-sg
API.
Bart.
next prev parent reply other threads:[~2015-09-17 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 13:42 [PATCH v2 0/4] scsi: cleanup ioctl headers and provide UAPI versions Paolo Bonzini
2015-09-17 13:42 ` [PATCH v2 1/4] scsi: remove old-style type names from sg.h Paolo Bonzini
2015-09-17 15:24 ` Bart Van Assche
2015-09-17 13:42 ` [PATCH v2 2/4] scsi: cleanup scsi/scsi_ioctl.h Paolo Bonzini
2015-09-17 15:27 ` Bart Van Assche
2015-09-17 13:42 ` [PATCH v2 3/4] scsi: move all obsolete ioctls to scsi/scsi_ioctl.h Paolo Bonzini
2015-09-17 15:26 ` Bart Van Assche
2015-09-17 13:47 ` [PATCH v2 4/4] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h Paolo Bonzini
2015-09-17 15:32 ` Bart Van Assche [this message]
2015-09-25 8:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FADCFF.5000104@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).