From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian King Subject: Re: [PATCH v2 18/30] cxlflash: Remove dual port online dependency Date: Tue, 22 Sep 2015 15:50:06 -0500 Message-ID: <5601BEFE.8060308@linux.vnet.ibm.com> References: <1442438635-49044-1-git-send-email-mrochs@linux.vnet.ibm.com> <1442439038-49894-1-git-send-email-mrochs@linux.vnet.ibm.com> <56007E7E.3090804@linux.vnet.ibm.com> <7DACBD20-4923-48A3-A773-829A938E34C9@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from e31.co.us.ibm.com ([32.97.110.149]:42044 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933514AbbIVUuM (ORCPT ); Tue, 22 Sep 2015 16:50:12 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 Sep 2015 14:50:11 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 0682619D8040 for ; Tue, 22 Sep 2015 14:41:02 -0600 (MDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t8MKl4i49240858 for ; Tue, 22 Sep 2015 13:47:04 -0700 Received: from d03av05.boulder.ibm.com (localhost [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t8MKo6Kj029897 for ; Tue, 22 Sep 2015 14:50:08 -0600 In-Reply-To: <7DACBD20-4923-48A3-A773-829A938E34C9@linux.vnet.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Matthew R. Ochs" Cc: linux-scsi@vger.kernel.org, James Bottomley , "Nicholas A. Bellinger" , Ian Munsie , Daniel Axtens , Andrew Donnellan , Michael Neuling , linuxppc-dev@lists.ozlabs.org, "Manoj N. Kumar" On 09/22/2015 03:44 PM, Matthew R. Ochs wrote: >> On Sep 21, 2015, at 5:02 PM, Brian King wrote: >> On 09/16/2015 04:30 PM, Matthew R. Ochs wrote: >>> At present, both ports must be online for the device to >>> configure properly. Remove this dependency and the unnecessary >>> internal LUN override logic as well. Additionally, as a refactoring >>> measure, change the return code variable name to match that used >>> throughout the driver. >> >> Doesn't this also change the behavior to no longer fail init_afu even >> if BOTH ports fail to go offline in the reconfig case. Is that OK? > > Correct, there is a change in behavior but it is not an issue. > ok. Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center