* [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
@ 2015-09-10 9:23 Laurent Vivier
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
` (6 more replies)
0 siblings, 7 replies; 18+ messages in thread
From: Laurent Vivier @ 2015-09-10 9:23 UTC (permalink / raw)
To: linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini, lvivier
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
I resend this patch as James was not cc'ed.
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 6a41c36..3e76490 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
MODULE_LICENSE("GPL");
MODULE_VERSION(IBMVSCSI_VERSION);
-module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
+module_param_named(max_id, max_id, int, S_IRUGO);
MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
-module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
+module_param_named(max_channel, max_channel, int, S_IRUGO);
MODULE_PARM_DESC(max_channel, "Largest channel value");
module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
--
2.1.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
@ 2015-09-10 9:23 ` Laurent Vivier
2015-09-11 0:53 ` David Gibson
` (3 more replies)
2015-09-10 9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
` (5 subsequent siblings)
6 siblings, 4 replies; 18+ messages in thread
From: Laurent Vivier @ 2015-09-10 9:23 UTC (permalink / raw)
To: linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini, lvivier
As devices with values greater than that are silently ignored,
this gives some hints to the sys admin to know why he doesn't see
his devices...
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 3e76490..f9d7ec4 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -106,9 +106,9 @@ MODULE_LICENSE("GPL");
MODULE_VERSION(IBMVSCSI_VERSION);
module_param_named(max_id, max_id, int, S_IRUGO);
-MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
+MODULE_PARM_DESC(max_id, "Largest ID value for each channel [Default=64]");
module_param_named(max_channel, max_channel, int, S_IRUGO);
-MODULE_PARM_DESC(max_channel, "Largest channel value");
+MODULE_PARM_DESC(max_channel, "Largest channel value [Default=3]");
module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
module_param_named(max_requests, max_requests, int, S_IRUGO);
@@ -2294,6 +2294,10 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
host->max_channel = max_channel;
host->max_cmd_len = 16;
+ dev_info(dev,
+ "Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n",
+ host->max_id, host->max_lun, host->max_channel);
+
if (scsi_add_host(hostdata->host, hostdata->dev))
goto add_host_failed;
--
2.1.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 3/3] ibmvsci: Allow to configure maximum LUN
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
@ 2015-09-10 9:23 ` Laurent Vivier
2015-09-11 0:54 ` David Gibson
` (3 more replies)
2015-09-11 0:52 ` [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only David Gibson
` (4 subsequent siblings)
6 siblings, 4 replies; 18+ messages in thread
From: Laurent Vivier @ 2015-09-10 9:23 UTC (permalink / raw)
To: linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini, lvivier
QEMU allows until 32 LUNs.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index f9d7ec4..e5478b0 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -84,6 +84,7 @@
*/
static int max_id = 64;
static int max_channel = 3;
+static int max_lun = 8;
static int init_timeout = 300;
static int login_timeout = 60;
static int info_timeout = 30;
@@ -117,6 +118,8 @@ module_param_named(fast_fail, fast_fail, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(fast_fail, "Enable fast fail. [Default=1]");
module_param_named(client_reserve, client_reserve, int, S_IRUGO );
MODULE_PARM_DESC(client_reserve, "Attempt client managed reserve/release");
+module_param(max_lun, int, S_IRUGO);
+MODULE_PARM_DESC(max_lun, "Maximum LUN value [Default=8]");
static void ibmvscsi_handle_crq(struct viosrp_crq *crq,
struct ibmvscsi_host_data *hostdata);
@@ -2289,7 +2292,7 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
goto init_pool_failed;
}
- host->max_lun = 8;
+ host->max_lun = max_lun;
host->max_id = max_id;
host->max_channel = max_channel;
host->max_cmd_len = 16;
--
2.1.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
2015-09-10 9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
@ 2015-09-11 0:52 ` David Gibson
2015-09-24 16:15 ` Laurent Vivier
` (3 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: David Gibson @ 2015-09-11 0:52 UTC (permalink / raw)
To: Laurent Vivier
Cc: linux-scsi, linux-kernel, James E.J. Bottomley, Tyrel Datwyler,
thuth, pbonzini
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
On Thu, 10 Sep 2015 11:23:12 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing writable attribute.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> I resend this patch as James was not cc'ed.
>
> drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 6a41c36..3e76490 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
> MODULE_LICENSE("GPL");
> MODULE_VERSION(IBMVSCSI_VERSION);
>
> -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
> +module_param_named(max_id, max_id, int, S_IRUGO);
> MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
> -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
> +module_param_named(max_channel, max_channel, int, S_IRUGO);
> MODULE_PARM_DESC(max_channel, "Largest channel value");
> module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
> --
> 2.1.0
>
--
David Gibson <dgibson@redhat.com>
Senior Software Engineer, Virtualization, Red Hat
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
@ 2015-09-11 0:53 ` David Gibson
2015-09-24 16:16 ` Laurent Vivier
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: David Gibson @ 2015-09-11 0:53 UTC (permalink / raw)
To: Laurent Vivier
Cc: linux-scsi, linux-kernel, James E.J. Bottomley, Tyrel Datwyler,
thuth, pbonzini
[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]
On Thu, 10 Sep 2015 11:23:13 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> As devices with values greater than that are silently ignored,
> this gives some hints to the sys admin to know why he doesn't see
> his devices...
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 3e76490..f9d7ec4 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -106,9 +106,9 @@ MODULE_LICENSE("GPL");
> MODULE_VERSION(IBMVSCSI_VERSION);
>
> module_param_named(max_id, max_id, int, S_IRUGO);
> -MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
> +MODULE_PARM_DESC(max_id, "Largest ID value for each channel [Default=64]");
> module_param_named(max_channel, max_channel, int, S_IRUGO);
> -MODULE_PARM_DESC(max_channel, "Largest channel value");
> +MODULE_PARM_DESC(max_channel, "Largest channel value [Default=3]");
> module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
> module_param_named(max_requests, max_requests, int, S_IRUGO);
> @@ -2294,6 +2294,10 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> host->max_channel = max_channel;
> host->max_cmd_len = 16;
>
> + dev_info(dev,
> + "Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n",
> + host->max_id, host->max_lun, host->max_channel);
> +
> if (scsi_add_host(hostdata->host, hostdata->dev))
> goto add_host_failed;
>
> --
> 2.1.0
>
--
David Gibson <dgibson@redhat.com>
Senior Software Engineer, Virtualization, Red Hat
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN
2015-09-10 9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
@ 2015-09-11 0:54 ` David Gibson
2015-09-24 16:16 ` Laurent Vivier
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: David Gibson @ 2015-09-11 0:54 UTC (permalink / raw)
To: Laurent Vivier
Cc: linux-scsi, linux-kernel, James E.J. Bottomley, Tyrel Datwyler,
thuth, pbonzini
[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]
On Thu, 10 Sep 2015 11:23:14 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> QEMU allows until 32 LUNs.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index f9d7ec4..e5478b0 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -84,6 +84,7 @@
> */
> static int max_id = 64;
> static int max_channel = 3;
> +static int max_lun = 8;
> static int init_timeout = 300;
> static int login_timeout = 60;
> static int info_timeout = 30;
> @@ -117,6 +118,8 @@ module_param_named(fast_fail, fast_fail, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(fast_fail, "Enable fast fail. [Default=1]");
> module_param_named(client_reserve, client_reserve, int, S_IRUGO );
> MODULE_PARM_DESC(client_reserve, "Attempt client managed reserve/release");
> +module_param(max_lun, int, S_IRUGO);
> +MODULE_PARM_DESC(max_lun, "Maximum LUN value [Default=8]");
>
> static void ibmvscsi_handle_crq(struct viosrp_crq *crq,
> struct ibmvscsi_host_data *hostdata);
> @@ -2289,7 +2292,7 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> goto init_pool_failed;
> }
>
> - host->max_lun = 8;
> + host->max_lun = max_lun;
> host->max_id = max_id;
> host->max_channel = max_channel;
> host->max_cmd_len = 16;
> --
> 2.1.0
>
--
David Gibson <dgibson@redhat.com>
Senior Software Engineer, Virtualization, Red Hat
--
David Gibson <dgibson@redhat.com>
Senior Software Engineer, Virtualization, Red Hat
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
` (2 preceding siblings ...)
2015-09-11 0:52 ` [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only David Gibson
@ 2015-09-24 16:15 ` Laurent Vivier
2015-09-24 17:28 ` Brian King
` (2 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Laurent Vivier @ 2015-09-24 16:15 UTC (permalink / raw)
To: linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini
Ping ?
On 10/09/2015 11:23, Laurent Vivier wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing writable attribute.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> I resend this patch as James was not cc'ed.
>
> drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 6a41c36..3e76490 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
> MODULE_LICENSE("GPL");
> MODULE_VERSION(IBMVSCSI_VERSION);
>
> -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
> +module_param_named(max_id, max_id, int, S_IRUGO);
> MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
> -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
> +module_param_named(max_channel, max_channel, int, S_IRUGO);
> MODULE_PARM_DESC(max_channel, "Largest channel value");
> module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
2015-09-11 0:53 ` David Gibson
@ 2015-09-24 16:16 ` Laurent Vivier
2015-09-24 17:29 ` Brian King
2015-09-28 21:39 ` Tyrel Datwyler
3 siblings, 0 replies; 18+ messages in thread
From: Laurent Vivier @ 2015-09-24 16:16 UTC (permalink / raw)
To: linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini
Ping ?
On 10/09/2015 11:23, Laurent Vivier wrote:
> As devices with values greater than that are silently ignored,
> this gives some hints to the sys admin to know why he doesn't see
> his devices...
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 3e76490..f9d7ec4 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -106,9 +106,9 @@ MODULE_LICENSE("GPL");
> MODULE_VERSION(IBMVSCSI_VERSION);
>
> module_param_named(max_id, max_id, int, S_IRUGO);
> -MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
> +MODULE_PARM_DESC(max_id, "Largest ID value for each channel [Default=64]");
> module_param_named(max_channel, max_channel, int, S_IRUGO);
> -MODULE_PARM_DESC(max_channel, "Largest channel value");
> +MODULE_PARM_DESC(max_channel, "Largest channel value [Default=3]");
> module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
> module_param_named(max_requests, max_requests, int, S_IRUGO);
> @@ -2294,6 +2294,10 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> host->max_channel = max_channel;
> host->max_cmd_len = 16;
>
> + dev_info(dev,
> + "Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n",
> + host->max_id, host->max_lun, host->max_channel);
> +
> if (scsi_add_host(hostdata->host, hostdata->dev))
> goto add_host_failed;
>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN
2015-09-10 9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
2015-09-11 0:54 ` David Gibson
@ 2015-09-24 16:16 ` Laurent Vivier
2015-09-24 17:38 ` Brian King
2015-09-28 21:39 ` Tyrel Datwyler
3 siblings, 0 replies; 18+ messages in thread
From: Laurent Vivier @ 2015-09-24 16:16 UTC (permalink / raw)
To: linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini
Ping ?
On 10/09/2015 11:23, Laurent Vivier wrote:
> QEMU allows until 32 LUNs.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index f9d7ec4..e5478b0 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -84,6 +84,7 @@
> */
> static int max_id = 64;
> static int max_channel = 3;
> +static int max_lun = 8;
> static int init_timeout = 300;
> static int login_timeout = 60;
> static int info_timeout = 30;
> @@ -117,6 +118,8 @@ module_param_named(fast_fail, fast_fail, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(fast_fail, "Enable fast fail. [Default=1]");
> module_param_named(client_reserve, client_reserve, int, S_IRUGO );
> MODULE_PARM_DESC(client_reserve, "Attempt client managed reserve/release");
> +module_param(max_lun, int, S_IRUGO);
> +MODULE_PARM_DESC(max_lun, "Maximum LUN value [Default=8]");
>
> static void ibmvscsi_handle_crq(struct viosrp_crq *crq,
> struct ibmvscsi_host_data *hostdata);
> @@ -2289,7 +2292,7 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> goto init_pool_failed;
> }
>
> - host->max_lun = 8;
> + host->max_lun = max_lun;
> host->max_id = max_id;
> host->max_channel = max_channel;
> host->max_cmd_len = 16;
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
` (3 preceding siblings ...)
2015-09-24 16:15 ` Laurent Vivier
@ 2015-09-24 17:28 ` Brian King
2015-09-28 21:38 ` Tyrel Datwyler
2015-10-13 21:23 ` Laurent Vivier
6 siblings, 0 replies; 18+ messages in thread
From: Brian King @ 2015-09-24 17:28 UTC (permalink / raw)
To: Laurent Vivier, linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
2015-09-11 0:53 ` David Gibson
2015-09-24 16:16 ` Laurent Vivier
@ 2015-09-24 17:29 ` Brian King
2015-09-28 21:39 ` Tyrel Datwyler
3 siblings, 0 replies; 18+ messages in thread
From: Brian King @ 2015-09-24 17:29 UTC (permalink / raw)
To: Laurent Vivier, linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN
2015-09-10 9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
2015-09-11 0:54 ` David Gibson
2015-09-24 16:16 ` Laurent Vivier
@ 2015-09-24 17:38 ` Brian King
2015-09-28 21:39 ` Tyrel Datwyler
3 siblings, 0 replies; 18+ messages in thread
From: Brian King @ 2015-09-24 17:38 UTC (permalink / raw)
To: Laurent Vivier, linux-scsi, linux-kernel, James E.J. Bottomley
Cc: Tyrel Datwyler, dgibson, thuth, pbonzini
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
` (4 preceding siblings ...)
2015-09-24 17:28 ` Brian King
@ 2015-09-28 21:38 ` Tyrel Datwyler
2015-10-13 21:23 ` Laurent Vivier
6 siblings, 0 replies; 18+ messages in thread
From: Tyrel Datwyler @ 2015-09-28 21:38 UTC (permalink / raw)
To: Laurent Vivier, linux-scsi, linux-kernel, James E.J. Bottomley
Cc: dgibson, thuth, pbonzini
On 09/10/2015 02:23 AM, Laurent Vivier wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing writable attribute.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> ---
> I resend this patch as James was not cc'ed.
>
> drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 6a41c36..3e76490 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
> MODULE_LICENSE("GPL");
> MODULE_VERSION(IBMVSCSI_VERSION);
>
> -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
> +module_param_named(max_id, max_id, int, S_IRUGO);
> MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
> -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
> +module_param_named(max_channel, max_channel, int, S_IRUGO);
> MODULE_PARM_DESC(max_channel, "Largest channel value");
> module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
` (2 preceding siblings ...)
2015-09-24 17:29 ` Brian King
@ 2015-09-28 21:39 ` Tyrel Datwyler
3 siblings, 0 replies; 18+ messages in thread
From: Tyrel Datwyler @ 2015-09-28 21:39 UTC (permalink / raw)
To: Laurent Vivier, linux-scsi, linux-kernel, James E.J. Bottomley
Cc: dgibson, thuth, pbonzini
On 09/10/2015 02:23 AM, Laurent Vivier wrote:
> As devices with values greater than that are silently ignored,
> this gives some hints to the sys admin to know why he doesn't see
> his devices...
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 3e76490..f9d7ec4 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -106,9 +106,9 @@ MODULE_LICENSE("GPL");
> MODULE_VERSION(IBMVSCSI_VERSION);
>
> module_param_named(max_id, max_id, int, S_IRUGO);
> -MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
> +MODULE_PARM_DESC(max_id, "Largest ID value for each channel [Default=64]");
> module_param_named(max_channel, max_channel, int, S_IRUGO);
> -MODULE_PARM_DESC(max_channel, "Largest channel value");
> +MODULE_PARM_DESC(max_channel, "Largest channel value [Default=3]");
> module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
> module_param_named(max_requests, max_requests, int, S_IRUGO);
> @@ -2294,6 +2294,10 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> host->max_channel = max_channel;
> host->max_cmd_len = 16;
>
> + dev_info(dev,
> + "Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n",
> + host->max_id, host->max_lun, host->max_channel);
> +
> if (scsi_add_host(hostdata->host, hostdata->dev))
> goto add_host_failed;
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN
2015-09-10 9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
` (2 preceding siblings ...)
2015-09-24 17:38 ` Brian King
@ 2015-09-28 21:39 ` Tyrel Datwyler
3 siblings, 0 replies; 18+ messages in thread
From: Tyrel Datwyler @ 2015-09-28 21:39 UTC (permalink / raw)
To: Laurent Vivier, linux-scsi, linux-kernel, James E.J. Bottomley
Cc: dgibson, thuth, pbonzini
On 09/10/2015 02:23 AM, Laurent Vivier wrote:
> QEMU allows until 32 LUNs.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index f9d7ec4..e5478b0 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -84,6 +84,7 @@
> */
> static int max_id = 64;
> static int max_channel = 3;
> +static int max_lun = 8;
> static int init_timeout = 300;
> static int login_timeout = 60;
> static int info_timeout = 30;
> @@ -117,6 +118,8 @@ module_param_named(fast_fail, fast_fail, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(fast_fail, "Enable fast fail. [Default=1]");
> module_param_named(client_reserve, client_reserve, int, S_IRUGO );
> MODULE_PARM_DESC(client_reserve, "Attempt client managed reserve/release");
> +module_param(max_lun, int, S_IRUGO);
> +MODULE_PARM_DESC(max_lun, "Maximum LUN value [Default=8]");
>
> static void ibmvscsi_handle_crq(struct viosrp_crq *crq,
> struct ibmvscsi_host_data *hostdata);
> @@ -2289,7 +2292,7 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> goto init_pool_failed;
> }
>
> - host->max_lun = 8;
> + host->max_lun = max_lun;
> host->max_id = max_id;
> host->max_channel = max_channel;
> host->max_cmd_len = 16;
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
` (5 preceding siblings ...)
2015-09-28 21:38 ` Tyrel Datwyler
@ 2015-10-13 21:23 ` Laurent Vivier
2015-10-27 15:38 ` Laurent Vivier
6 siblings, 1 reply; 18+ messages in thread
From: Laurent Vivier @ 2015-10-13 21:23 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: linux-scsi, linux-kernel, Tyrel Datwyler, dgibson, thuth,
pbonzini
James,
this series has been reviewed and ack'ed,
as SCSI maintainer, could you take it ?
Laurent
On 10/09/2015 11:23, Laurent Vivier wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing writable attribute.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> I resend this patch as James was not cc'ed.
>
> drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 6a41c36..3e76490 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
> MODULE_LICENSE("GPL");
> MODULE_VERSION(IBMVSCSI_VERSION);
>
> -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
> +module_param_named(max_id, max_id, int, S_IRUGO);
> MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
> -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
> +module_param_named(max_channel, max_channel, int, S_IRUGO);
> MODULE_PARM_DESC(max_channel, "Largest channel value");
> module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
2015-10-13 21:23 ` Laurent Vivier
@ 2015-10-27 15:38 ` Laurent Vivier
2015-11-03 5:00 ` Martin K. Petersen
0 siblings, 1 reply; 18+ messages in thread
From: Laurent Vivier @ 2015-10-27 15:38 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: linux-scsi, linux-kernel, Tyrel Datwyler, dgibson, thuth,
pbonzini
Ping ?
On 13/10/2015 23:23, Laurent Vivier wrote:
> James,
>
> this series has been reviewed and ack'ed,
> as SCSI maintainer, could you take it ?
>
> Laurent
>
> On 10/09/2015 11:23, Laurent Vivier wrote:
>> The value of the parameter is never re-read by the driver,
>> so a new value is ignored. Let know the user he
>> can't modify it by removing writable attribute.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>> I resend this patch as James was not cc'ed.
>>
>> drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
>> index 6a41c36..3e76490 100644
>> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
>> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
>> @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
>> MODULE_LICENSE("GPL");
>> MODULE_VERSION(IBMVSCSI_VERSION);
>>
>> -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
>> +module_param_named(max_id, max_id, int, S_IRUGO);
>> MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
>> -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
>> +module_param_named(max_channel, max_channel, int, S_IRUGO);
>> MODULE_PARM_DESC(max_channel, "Largest channel value");
>> module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
>> MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
2015-10-27 15:38 ` Laurent Vivier
@ 2015-11-03 5:00 ` Martin K. Petersen
0 siblings, 0 replies; 18+ messages in thread
From: Martin K. Petersen @ 2015-11-03 5:00 UTC (permalink / raw)
To: Laurent Vivier
Cc: James E.J. Bottomley, linux-scsi, linux-kernel, Tyrel Datwyler,
dgibson, thuth, pbonzini
>>>>> "Laurent" == Laurent Vivier <lvivier@redhat.com> writes:
Laurent> Ping ?
>> this series has been reviewed and ack'ed, as SCSI maintainer, could
>> you take it ?
My mailbox doesn't reach quite far enough back in time to pick this up
and I'd rather not have to deal with mail archive-mangled versions.
Please apply the relevant Reviewed-by tags and repost.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2015-11-03 5:00 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
2015-09-11 0:53 ` David Gibson
2015-09-24 16:16 ` Laurent Vivier
2015-09-24 17:29 ` Brian King
2015-09-28 21:39 ` Tyrel Datwyler
2015-09-10 9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
2015-09-11 0:54 ` David Gibson
2015-09-24 16:16 ` Laurent Vivier
2015-09-24 17:38 ` Brian King
2015-09-28 21:39 ` Tyrel Datwyler
2015-09-11 0:52 ` [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only David Gibson
2015-09-24 16:15 ` Laurent Vivier
2015-09-24 17:28 ` Brian King
2015-09-28 21:38 ` Tyrel Datwyler
2015-10-13 21:23 ` Laurent Vivier
2015-10-27 15:38 ` Laurent Vivier
2015-11-03 5:00 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).