From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Laurent Vivier <lvivier@redhat.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@odin.com>
Cc: dgibson@redhat.com, thuth@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN
Date: Mon, 28 Sep 2015 14:39:34 -0700 [thread overview]
Message-ID: <5609B396.70302@linux.vnet.ibm.com> (raw)
In-Reply-To: <1441876994-16821-3-git-send-email-lvivier@redhat.com>
On 09/10/2015 02:23 AM, Laurent Vivier wrote:
> QEMU allows until 32 LUNs.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index f9d7ec4..e5478b0 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -84,6 +84,7 @@
> */
> static int max_id = 64;
> static int max_channel = 3;
> +static int max_lun = 8;
> static int init_timeout = 300;
> static int login_timeout = 60;
> static int info_timeout = 30;
> @@ -117,6 +118,8 @@ module_param_named(fast_fail, fast_fail, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(fast_fail, "Enable fast fail. [Default=1]");
> module_param_named(client_reserve, client_reserve, int, S_IRUGO );
> MODULE_PARM_DESC(client_reserve, "Attempt client managed reserve/release");
> +module_param(max_lun, int, S_IRUGO);
> +MODULE_PARM_DESC(max_lun, "Maximum LUN value [Default=8]");
>
> static void ibmvscsi_handle_crq(struct viosrp_crq *crq,
> struct ibmvscsi_host_data *hostdata);
> @@ -2289,7 +2292,7 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> goto init_pool_failed;
> }
>
> - host->max_lun = 8;
> + host->max_lun = max_lun;
> host->max_id = max_id;
> host->max_channel = max_channel;
> host->max_cmd_len = 16;
>
next prev parent reply other threads:[~2015-09-28 21:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 9:23 [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier
2015-09-10 9:23 ` [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel Laurent Vivier
2015-09-11 0:53 ` David Gibson
2015-09-24 16:16 ` Laurent Vivier
2015-09-24 17:29 ` Brian King
2015-09-28 21:39 ` Tyrel Datwyler
2015-09-10 9:23 ` [PATCH 3/3] ibmvsci: Allow to configure maximum LUN Laurent Vivier
2015-09-11 0:54 ` David Gibson
2015-09-24 16:16 ` Laurent Vivier
2015-09-24 17:38 ` Brian King
2015-09-28 21:39 ` Tyrel Datwyler [this message]
2015-09-11 0:52 ` [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only David Gibson
2015-09-24 16:15 ` Laurent Vivier
2015-09-24 17:28 ` Brian King
2015-09-28 21:38 ` Tyrel Datwyler
2015-10-13 21:23 ` Laurent Vivier
2015-10-27 15:38 ` Laurent Vivier
2015-11-03 5:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5609B396.70302@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=JBottomley@odin.com \
--cc=dgibson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).