From: Lee Duncan <lduncan@suse.com>
To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Tejun Heo <tj@kernel.org>, Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt
Date: Wed, 7 Oct 2015 16:52:30 -0700 [thread overview]
Message-ID: <5615B03E.6080302@suse.com> (raw)
In-Reply-To: <cover.1444157464.git.lduncan@suse.com>
Duplicate email, please ignore
On 10/07/2015 04:47 PM, Lee Duncan wrote:
> This patch updates the SCSI hosts module to use the idr
> index-management routines to manage its host_no index instead
> of using an ATOMIC integer. This means that host numbers
> can now be reclaimed and re-used.
>
> It also updates the hosts module to use the idr routine idr_find()
> to lookup hosts based on the host number, hopefully speeding
> up said lookup.
>
> After noticing that my idr calling sequences where very close
> to those in other modules, I considered creating some idr helper
> functions (and using them), but because idr usage almost always
> requires the caller to manage their own locks, I gave up on
> this approach (as suggested by Tejon -- thank you).
>
> Changes from v1:
> - no longer using helper routines
> Changes from v2:
> - added back missing scsi_host_get() in scsi_host_lookup()
>
> Lee Duncan (1):
> SCSI: update hosts module to use idr index management
>
> drivers/scsi/hosts.c | 61 ++++++++++++++++++++++++++--------------------------
> 1 file changed, 31 insertions(+), 30 deletions(-)
>
--
Lee Duncan
SUSE Labs
prev parent reply other threads:[~2015-10-07 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 19:08 [PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt Lee Duncan
2015-10-06 19:08 ` [PATCHv3 1/1] SCSI: update hosts module to use idr index management Lee Duncan
2015-10-06 19:19 ` James Bottomley
2015-10-06 21:44 ` Lee Duncan
2015-10-07 23:52 ` Lee Duncan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5615B03E.6080302@suse.com \
--to=lduncan@suse.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox