* [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
@ 2015-05-22 0:00 Julian Calaby
2015-05-22 0:05 ` Julian Calaby
0 siblings, 1 reply; 10+ messages in thread
From: Julian Calaby @ 2015-05-22 0:00 UTC (permalink / raw)
To: linux-scsi
Cc: Julian Calaby, qla2xxx-upstream, James E.J. Bottomley,
Linux Firmware Maintainers
Some qla2xxx devices have firmware stored in flash on the device,
however for debugging and triage purposes, Qlogic staff like to
be able to load known-good versions of these firmwares through
request_firmware().
These firmware files were never distributed and are unlikely to ever
be released publically, so to hide these missing firmware files from
scripts which check such things, (e.g. Debian's initramfs-tools) put
them behind a new EXPERT Kconfig option.
Cc: <qla2xxx-upstream@qlogic.com>
Cc: James E.J. Bottomley <JBottomley@odin.com>
Cc: Linux Firmware Maintainers <linux-firmware@kernel.org>
Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
---
drivers/scsi/qla2xxx/Kconfig | 25 +++++++++++++++++++++++++
drivers/scsi/qla2xxx/qla_os.c | 40 +++++++++++++++++++++++++++-------------
2 files changed, 52 insertions(+), 13 deletions(-)
This is against linux-next @next-20150520 and has been compile
tested only.
diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
index 33f60c9..31e9db4 100644
--- a/drivers/scsi/qla2xxx/Kconfig
+++ b/drivers/scsi/qla2xxx/Kconfig
@@ -31,6 +31,31 @@ config SCSI_QLA_FC
They are also included in the linux-firmware tree as well.
+ This driver also supports some adapters with firmware stored
+ onboard in flash.
+
+config SCSI_QLA_FC_TRIAGE
+ bool "Firmware loading support for flash based adapters"
+ depends on SCSI_QLA_FC
+ depends on EXPERT
+ default n
+ ---help---
+ Add firmware definitions for adapters with firmware stored
+ onboard in flash.
+
+ This requires the following firmware files which are not
+ distributed:
+
+ ISP Firmware Filename
+ ---------- -----------------
+ 81xx ql8100_fw.bin
+ 82xx ql8200_fw.bin
+
+ This option should only be enabled by Qlogic support staff
+ as these firmware files are not available publically.
+
+ If unsure say N.
+
config TCM_QLA2XXX
tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
depends on SCSI_QLA_FC && TARGET_CORE
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 7462dd7..da98d83 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -5284,11 +5284,14 @@ qla2x00_timer(scsi_qla_host_t *vha)
#define FW_ISP2322 3
#define FW_ISP24XX 4
#define FW_ISP25XX 5
-#define FW_ISP81XX 6
-#define FW_ISP82XX 7
-#define FW_ISP2031 8
-#define FW_ISP8031 9
-#define FW_ISP27XX 10
+#define FW_ISP2031 6
+#define FW_ISP8031 7
+#define FW_ISP27XX 8
+
+#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
+#define FW_ISP81XX 9
+#define FW_ISP82XX 10
+#endif
#define FW_FILE_ISP21XX "ql2100_fw.bin"
#define FW_FILE_ISP22XX "ql2200_fw.bin"
@@ -5296,12 +5299,14 @@ qla2x00_timer(scsi_qla_host_t *vha)
#define FW_FILE_ISP2322 "ql2322_fw.bin"
#define FW_FILE_ISP24XX "ql2400_fw.bin"
#define FW_FILE_ISP25XX "ql2500_fw.bin"
-#define FW_FILE_ISP81XX "ql8100_fw.bin"
-#define FW_FILE_ISP82XX "ql8200_fw.bin"
#define FW_FILE_ISP2031 "ql2600_fw.bin"
#define FW_FILE_ISP8031 "ql8300_fw.bin"
#define FW_FILE_ISP27XX "ql2700_fw.bin"
+#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
+#define FW_FILE_ISP81XX "ql8100_fw.bin"
+#define FW_FILE_ISP82XX "ql8200_fw.bin"
+#endif
static DEFINE_MUTEX(qla_fw_lock);
@@ -5312,11 +5317,13 @@ static struct fw_blob qla_fw_blobs[FW_BLOBS] = {
{ .name = FW_FILE_ISP2322, .segs = { 0x800, 0x1c000, 0x1e000, 0 }, },
{ .name = FW_FILE_ISP24XX, },
{ .name = FW_FILE_ISP25XX, },
- { .name = FW_FILE_ISP81XX, },
- { .name = FW_FILE_ISP82XX, },
{ .name = FW_FILE_ISP2031, },
{ .name = FW_FILE_ISP8031, },
{ .name = FW_FILE_ISP27XX, },
+#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
+ { .name = FW_FILE_ISP81XX, },
+ { .name = FW_FILE_ISP82XX, },
+#endif
};
struct fw_blob *
@@ -5337,16 +5344,18 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
blob = &qla_fw_blobs[FW_ISP24XX];
} else if (IS_QLA25XX(ha)) {
blob = &qla_fw_blobs[FW_ISP25XX];
- } else if (IS_QLA81XX(ha)) {
- blob = &qla_fw_blobs[FW_ISP81XX];
- } else if (IS_QLA82XX(ha)) {
- blob = &qla_fw_blobs[FW_ISP82XX];
} else if (IS_QLA2031(ha)) {
blob = &qla_fw_blobs[FW_ISP2031];
} else if (IS_QLA8031(ha)) {
blob = &qla_fw_blobs[FW_ISP8031];
} else if (IS_QLA27XX(ha)) {
blob = &qla_fw_blobs[FW_ISP27XX];
+#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
+ } else if (IS_QLA81XX(ha)) {
+ blob = &qla_fw_blobs[FW_ISP81XX];
+ } else if (IS_QLA82XX(ha)) {
+ blob = &qla_fw_blobs[FW_ISP82XX];
+#endif
} else {
return NULL;
}
@@ -5837,3 +5846,8 @@ MODULE_FIRMWARE(FW_FILE_ISP25XX);
MODULE_FIRMWARE(FW_FILE_ISP2031);
MODULE_FIRMWARE(FW_FILE_ISP8031);
MODULE_FIRMWARE(FW_FILE_ISP27XX);
+
+#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
+MODULE_FIRMWARE(FW_FILE_ISP81XX);
+MODULE_FIRMWARE(FW_FILE_ISP82XX);
+#endif
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
2015-05-22 0:00 [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware Julian Calaby
@ 2015-05-22 0:05 ` Julian Calaby
2015-10-07 15:13 ` Xose Vazquez Perez
0 siblings, 1 reply; 10+ messages in thread
From: Julian Calaby @ 2015-05-22 0:05 UTC (permalink / raw)
To: Xose Vazquez Perez
Cc: qla2xxx-upstream, linux-scsi, James E.J. Bottomley,
Linux Firmware Maintainers
Hi Xose,
Adding you to CC.
On Fri, May 22, 2015 at 10:00 AM, Julian Calaby <julian.calaby@gmail.com> wrote:
> Some qla2xxx devices have firmware stored in flash on the device,
> however for debugging and triage purposes, Qlogic staff like to
> be able to load known-good versions of these firmwares through
> request_firmware().
>
> These firmware files were never distributed and are unlikely to ever
> be released publically, so to hide these missing firmware files from
> scripts which check such things, (e.g. Debian's initramfs-tools) put
> them behind a new EXPERT Kconfig option.
>
> Cc: <qla2xxx-upstream@qlogic.com>
> Cc: James E.J. Bottomley <JBottomley@odin.com>
> Cc: Linux Firmware Maintainers <linux-firmware@kernel.org>
> Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/scsi/qla2xxx/Kconfig | 25 +++++++++++++++++++++++++
> drivers/scsi/qla2xxx/qla_os.c | 40 +++++++++++++++++++++++++++-------------
> 2 files changed, 52 insertions(+), 13 deletions(-)
>
> This is against linux-next @next-20150520 and has been compile
> tested only.
>
> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
> index 33f60c9..31e9db4 100644
> --- a/drivers/scsi/qla2xxx/Kconfig
> +++ b/drivers/scsi/qla2xxx/Kconfig
> @@ -31,6 +31,31 @@ config SCSI_QLA_FC
>
> They are also included in the linux-firmware tree as well.
>
> + This driver also supports some adapters with firmware stored
> + onboard in flash.
> +
> +config SCSI_QLA_FC_TRIAGE
> + bool "Firmware loading support for flash based adapters"
> + depends on SCSI_QLA_FC
> + depends on EXPERT
> + default n
> + ---help---
> + Add firmware definitions for adapters with firmware stored
> + onboard in flash.
> +
> + This requires the following firmware files which are not
> + distributed:
> +
> + ISP Firmware Filename
> + ---------- -----------------
> + 81xx ql8100_fw.bin
> + 82xx ql8200_fw.bin
> +
> + This option should only be enabled by Qlogic support staff
> + as these firmware files are not available publically.
> +
> + If unsure say N.
> +
> config TCM_QLA2XXX
> tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
> depends on SCSI_QLA_FC && TARGET_CORE
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 7462dd7..da98d83 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -5284,11 +5284,14 @@ qla2x00_timer(scsi_qla_host_t *vha)
> #define FW_ISP2322 3
> #define FW_ISP24XX 4
> #define FW_ISP25XX 5
> -#define FW_ISP81XX 6
> -#define FW_ISP82XX 7
> -#define FW_ISP2031 8
> -#define FW_ISP8031 9
> -#define FW_ISP27XX 10
> +#define FW_ISP2031 6
> +#define FW_ISP8031 7
> +#define FW_ISP27XX 8
> +
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +#define FW_ISP81XX 9
> +#define FW_ISP82XX 10
> +#endif
>
> #define FW_FILE_ISP21XX "ql2100_fw.bin"
> #define FW_FILE_ISP22XX "ql2200_fw.bin"
> @@ -5296,12 +5299,14 @@ qla2x00_timer(scsi_qla_host_t *vha)
> #define FW_FILE_ISP2322 "ql2322_fw.bin"
> #define FW_FILE_ISP24XX "ql2400_fw.bin"
> #define FW_FILE_ISP25XX "ql2500_fw.bin"
> -#define FW_FILE_ISP81XX "ql8100_fw.bin"
> -#define FW_FILE_ISP82XX "ql8200_fw.bin"
> #define FW_FILE_ISP2031 "ql2600_fw.bin"
> #define FW_FILE_ISP8031 "ql8300_fw.bin"
> #define FW_FILE_ISP27XX "ql2700_fw.bin"
>
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +#define FW_FILE_ISP81XX "ql8100_fw.bin"
> +#define FW_FILE_ISP82XX "ql8200_fw.bin"
> +#endif
>
> static DEFINE_MUTEX(qla_fw_lock);
>
> @@ -5312,11 +5317,13 @@ static struct fw_blob qla_fw_blobs[FW_BLOBS] = {
> { .name = FW_FILE_ISP2322, .segs = { 0x800, 0x1c000, 0x1e000, 0 }, },
> { .name = FW_FILE_ISP24XX, },
> { .name = FW_FILE_ISP25XX, },
> - { .name = FW_FILE_ISP81XX, },
> - { .name = FW_FILE_ISP82XX, },
> { .name = FW_FILE_ISP2031, },
> { .name = FW_FILE_ISP8031, },
> { .name = FW_FILE_ISP27XX, },
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> + { .name = FW_FILE_ISP81XX, },
> + { .name = FW_FILE_ISP82XX, },
> +#endif
> };
>
> struct fw_blob *
> @@ -5337,16 +5344,18 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
> blob = &qla_fw_blobs[FW_ISP24XX];
> } else if (IS_QLA25XX(ha)) {
> blob = &qla_fw_blobs[FW_ISP25XX];
> - } else if (IS_QLA81XX(ha)) {
> - blob = &qla_fw_blobs[FW_ISP81XX];
> - } else if (IS_QLA82XX(ha)) {
> - blob = &qla_fw_blobs[FW_ISP82XX];
> } else if (IS_QLA2031(ha)) {
> blob = &qla_fw_blobs[FW_ISP2031];
> } else if (IS_QLA8031(ha)) {
> blob = &qla_fw_blobs[FW_ISP8031];
> } else if (IS_QLA27XX(ha)) {
> blob = &qla_fw_blobs[FW_ISP27XX];
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> + } else if (IS_QLA81XX(ha)) {
> + blob = &qla_fw_blobs[FW_ISP81XX];
> + } else if (IS_QLA82XX(ha)) {
> + blob = &qla_fw_blobs[FW_ISP82XX];
> +#endif
> } else {
> return NULL;
> }
> @@ -5837,3 +5846,8 @@ MODULE_FIRMWARE(FW_FILE_ISP25XX);
> MODULE_FIRMWARE(FW_FILE_ISP2031);
> MODULE_FIRMWARE(FW_FILE_ISP8031);
> MODULE_FIRMWARE(FW_FILE_ISP27XX);
> +
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +MODULE_FIRMWARE(FW_FILE_ISP81XX);
> +MODULE_FIRMWARE(FW_FILE_ISP82XX);
> +#endif
> --
> 2.1.4
>
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
2015-05-22 0:05 ` Julian Calaby
@ 2015-10-07 15:13 ` Xose Vazquez Perez
2015-10-07 23:41 ` Julian Calaby
0 siblings, 1 reply; 10+ messages in thread
From: Xose Vazquez Perez @ 2015-10-07 15:13 UTC (permalink / raw)
To: Julian Calaby
Cc: qla2xxx-upstream, linux-scsi, James E.J. Bottomley,
Linux Firmware Maintainers
On Fri, May 22, 2015 at 10:00 AM, Julian Calaby <julian.calaby@gmail.com> wrote:
> Some qla2xxx devices have firmware stored in flash on the device,
> however for debugging and triage purposes, Qlogic staff like to
> be able to load known-good versions of these firmwares through
> request_firmware().
>
> These firmware files were never distributed and are unlikely to ever
> be released publically, so to hide these missing firmware files from
> scripts which check such things, (e.g. Debian's initramfs-tools) put
> them behind a new EXPERT Kconfig option.
What is state of this patch ?
> Cc: <qla2xxx-upstream@qlogic.com>
> Cc: James E.J. Bottomley <JBottomley@odin.com>
> Cc: Linux Firmware Maintainers <linux-firmware@kernel.org>
> Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/scsi/qla2xxx/Kconfig | 25 +++++++++++++++++++++++++
> drivers/scsi/qla2xxx/qla_os.c | 40 +++++++++++++++++++++++++++-------------
> 2 files changed, 52 insertions(+), 13 deletions(-)
>
> This is against linux-next @next-20150520 and has been compile
> tested only.
>
> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
> index 33f60c9..31e9db4 100644
> --- a/drivers/scsi/qla2xxx/Kconfig
> +++ b/drivers/scsi/qla2xxx/Kconfig
> @@ -31,6 +31,31 @@ config SCSI_QLA_FC
>
> They are also included in the linux-firmware tree as well.
>
> + This driver also supports some adapters with firmware stored
> + onboard in flash.
> +
> +config SCSI_QLA_FC_TRIAGE
> + bool "Firmware loading support for flash based adapters"
> + depends on SCSI_QLA_FC
> + depends on EXPERT
> + default n
> + ---help---
> + Add firmware definitions for adapters with firmware stored
> + onboard in flash.
> +
> + This requires the following firmware files which are not
> + distributed:
> +
> + ISP Firmware Filename
> + ---------- -----------------
> + 81xx ql8100_fw.bin
> + 82xx ql8200_fw.bin
> +
> + This option should only be enabled by Qlogic support staff
> + as these firmware files are not available publically.
> +
> + If unsure say N.
> +
> config TCM_QLA2XXX
> tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
> depends on SCSI_QLA_FC && TARGET_CORE
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 7462dd7..da98d83 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -5284,11 +5284,14 @@ qla2x00_timer(scsi_qla_host_t *vha)
> #define FW_ISP2322 3
> #define FW_ISP24XX 4
> #define FW_ISP25XX 5
> -#define FW_ISP81XX 6
> -#define FW_ISP82XX 7
> -#define FW_ISP2031 8
> -#define FW_ISP8031 9
> -#define FW_ISP27XX 10
> +#define FW_ISP2031 6
> +#define FW_ISP8031 7
> +#define FW_ISP27XX 8
> +
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +#define FW_ISP81XX 9
> +#define FW_ISP82XX 10
> +#endif
>
> #define FW_FILE_ISP21XX "ql2100_fw.bin"
> #define FW_FILE_ISP22XX "ql2200_fw.bin"
> @@ -5296,12 +5299,14 @@ qla2x00_timer(scsi_qla_host_t *vha)
> #define FW_FILE_ISP2322 "ql2322_fw.bin"
> #define FW_FILE_ISP24XX "ql2400_fw.bin"
> #define FW_FILE_ISP25XX "ql2500_fw.bin"
> -#define FW_FILE_ISP81XX "ql8100_fw.bin"
> -#define FW_FILE_ISP82XX "ql8200_fw.bin"
> #define FW_FILE_ISP2031 "ql2600_fw.bin"
> #define FW_FILE_ISP8031 "ql8300_fw.bin"
> #define FW_FILE_ISP27XX "ql2700_fw.bin"
>
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +#define FW_FILE_ISP81XX "ql8100_fw.bin"
> +#define FW_FILE_ISP82XX "ql8200_fw.bin"
> +#endif
>
> static DEFINE_MUTEX(qla_fw_lock);
>
> @@ -5312,11 +5317,13 @@ static struct fw_blob qla_fw_blobs[FW_BLOBS] = {
> { .name = FW_FILE_ISP2322, .segs = { 0x800, 0x1c000, 0x1e000, 0 }, },
> { .name = FW_FILE_ISP24XX, },
> { .name = FW_FILE_ISP25XX, },
> - { .name = FW_FILE_ISP81XX, },
> - { .name = FW_FILE_ISP82XX, },
> { .name = FW_FILE_ISP2031, },
> { .name = FW_FILE_ISP8031, },
> { .name = FW_FILE_ISP27XX, },
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> + { .name = FW_FILE_ISP81XX, },
> + { .name = FW_FILE_ISP82XX, },
> +#endif
> };
>
> struct fw_blob *
> @@ -5337,16 +5344,18 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
> blob = &qla_fw_blobs[FW_ISP24XX];
> } else if (IS_QLA25XX(ha)) {
> blob = &qla_fw_blobs[FW_ISP25XX];
> - } else if (IS_QLA81XX(ha)) {
> - blob = &qla_fw_blobs[FW_ISP81XX];
> - } else if (IS_QLA82XX(ha)) {
> - blob = &qla_fw_blobs[FW_ISP82XX];
> } else if (IS_QLA2031(ha)) {
> blob = &qla_fw_blobs[FW_ISP2031];
> } else if (IS_QLA8031(ha)) {
> blob = &qla_fw_blobs[FW_ISP8031];
> } else if (IS_QLA27XX(ha)) {
> blob = &qla_fw_blobs[FW_ISP27XX];
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> + } else if (IS_QLA81XX(ha)) {
> + blob = &qla_fw_blobs[FW_ISP81XX];
> + } else if (IS_QLA82XX(ha)) {
> + blob = &qla_fw_blobs[FW_ISP82XX];
> +#endif
> } else {
> return NULL;
> }
> @@ -5837,3 +5846,8 @@ MODULE_FIRMWARE(FW_FILE_ISP25XX);
> MODULE_FIRMWARE(FW_FILE_ISP2031);
> MODULE_FIRMWARE(FW_FILE_ISP8031);
> MODULE_FIRMWARE(FW_FILE_ISP27XX);
> +
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +MODULE_FIRMWARE(FW_FILE_ISP81XX);
> +MODULE_FIRMWARE(FW_FILE_ISP82XX);
> +#endif
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
2015-10-07 15:13 ` Xose Vazquez Perez
@ 2015-10-07 23:41 ` Julian Calaby
2015-10-08 15:46 ` Himanshu Madhani
0 siblings, 1 reply; 10+ messages in thread
From: Julian Calaby @ 2015-10-07 23:41 UTC (permalink / raw)
To: Xose Vazquez Perez
Cc: qla2xxx-upstream, linux-scsi, James E.J. Bottomley,
Linux Firmware Maintainers
Hi Xose,
On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez
<xose.vazquez@gmail.com> wrote:
> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby <julian.calaby@gmail.com> wrote:
>
>> Some qla2xxx devices have firmware stored in flash on the device,
>> however for debugging and triage purposes, Qlogic staff like to
>> be able to load known-good versions of these firmwares through
>> request_firmware().
>>
>> These firmware files were never distributed and are unlikely to ever
>> be released publically, so to hide these missing firmware files from
>> scripts which check such things, (e.g. Debian's initramfs-tools) put
>> them behind a new EXPERT Kconfig option.
>
>
> What is state of this patch ?
Apparently nobody cared, either from qLogic or linux-scsi.
I'm not overly fussed whether it goes in or not, it was more a point
in the discussion that proceeded it, however it does solve the
problems in the discussion that preceded it.
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
2015-10-07 23:41 ` Julian Calaby
@ 2015-10-08 15:46 ` Himanshu Madhani
2015-10-08 16:17 ` James Bottomley
0 siblings, 1 reply; 10+ messages in thread
From: Himanshu Madhani @ 2015-10-08 15:46 UTC (permalink / raw)
To: Julian Calaby, Xose Vazquez Perez
Cc: Dept-Eng QLA2xxx Upstream, linux-scsi, James E.J. Bottomley,
Linux Firmware Maintainers
[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]
On 10/7/15, 4:41 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:
>Hi Xose,
>
>On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez
><xose.vazquez@gmail.com> wrote:
>> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby
>><julian.calaby@gmail.com> wrote:
>>
>>> Some qla2xxx devices have firmware stored in flash on the device,
>>> however for debugging and triage purposes, Qlogic staff like to
>>> be able to load known-good versions of these firmwares through
>>> request_firmware().
>>>
>>> These firmware files were never distributed and are unlikely to ever
>>> be released publically, so to hide these missing firmware files from
>>> scripts which check such things, (e.g. Debian's initramfs-tools) put
>>> them behind a new EXPERT Kconfig option.
>>
>>
>> What is state of this patch ?
>
>Apparently nobody cared, either from qLogic or linux-scsi.
>
>I'm not overly fussed whether it goes in or not, it was more a point
>in the discussion that proceeded it, however it does solve the
>problems in the discussion that preceded it.
This patch Looks good.
Acked-By: Himanshu Madhani <himanshu.madhani@qlogic.com>
>
>Thanks,
>
>--
>Julian Calaby
>
>Email: julian.calaby@gmail.com
>Profile: http://www.google.com/profiles/julian.calaby/
>--
>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 5170 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
2015-10-08 15:46 ` Himanshu Madhani
@ 2015-10-08 16:17 ` James Bottomley
2015-10-08 17:38 ` Himanshu Madhani
2015-10-08 23:10 ` Julian Calaby
0 siblings, 2 replies; 10+ messages in thread
From: James Bottomley @ 2015-10-08 16:17 UTC (permalink / raw)
To: Himanshu Madhani
Cc: Julian Calaby, Xose Vazquez Perez, Dept-Eng QLA2xxx Upstream,
linux-scsi, Linux Firmware Maintainers
On Thu, 2015-10-08 at 15:46 +0000, Himanshu Madhani wrote:
>
> On 10/7/15, 4:41 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:
>
> >Hi Xose,
> >
> >On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez
> ><xose.vazquez@gmail.com> wrote:
> >> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby
> >><julian.calaby@gmail.com> wrote:
> >>
> >>> Some qla2xxx devices have firmware stored in flash on the device,
> >>> however for debugging and triage purposes, Qlogic staff like to
> >>> be able to load known-good versions of these firmwares through
> >>> request_firmware().
> >>>
> >>> These firmware files were never distributed and are unlikely to ever
> >>> be released publically, so to hide these missing firmware files from
> >>> scripts which check such things, (e.g. Debian's initramfs-tools) put
> >>> them behind a new EXPERT Kconfig option.
> >>
> >>
> >> What is state of this patch ?
> >
> >Apparently nobody cared, either from qLogic or linux-scsi.
> >
> >I'm not overly fussed whether it goes in or not, it was more a point
> >in the discussion that proceeded it, however it does solve the
> >problems in the discussion that preceded it.
>
> This patch Looks good.
>
> Acked-By: Himanshu Madhani <himanshu.madhani@qlogic.com>
Actually, this isn't helpful. You now add another option over which the
distributions have to make a choice. Is this interface necessary and
useful? If yes, then it should be compiled in and if not, just remove
it ... don't do death by 1000 Kconfig options.
James
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
2015-10-08 16:17 ` James Bottomley
@ 2015-10-08 17:38 ` Himanshu Madhani
2015-10-08 23:10 ` Julian Calaby
1 sibling, 0 replies; 10+ messages in thread
From: Himanshu Madhani @ 2015-10-08 17:38 UTC (permalink / raw)
To: James Bottomley
Cc: Julian Calaby, Xose Vazquez Perez, Dept-Eng QLA2xxx Upstream,
linux-scsi, Linux Firmware Maintainers
[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]
Hi James,
On 10/8/15, 9:17 AM, "James Bottomley"
<James.Bottomley@HansenPartnership.com> wrote:
>On Thu, 2015-10-08 at 15:46 +0000, Himanshu Madhani wrote:
>>
>> On 10/7/15, 4:41 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:
>>
>> >Hi Xose,
>> >
>> >On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez
>> ><xose.vazquez@gmail.com> wrote:
>> >> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby
>> >><julian.calaby@gmail.com> wrote:
>> >>
>> >>> Some qla2xxx devices have firmware stored in flash on the device,
>> >>> however for debugging and triage purposes, Qlogic staff like to
>> >>> be able to load known-good versions of these firmwares through
>> >>> request_firmware().
>> >>>
>> >>> These firmware files were never distributed and are unlikely to ever
>> >>> be released publically, so to hide these missing firmware files from
>> >>> scripts which check such things, (e.g. Debian's initramfs-tools) put
>> >>> them behind a new EXPERT Kconfig option.
>> >>
>> >>
>> >> What is state of this patch ?
>> >
>> >Apparently nobody cared, either from qLogic or linux-scsi.
>> >
>> >I'm not overly fussed whether it goes in or not, it was more a point
>> >in the discussion that proceeded it, however it does solve the
>> >problems in the discussion that preceded it.
>>
>> This patch Looks good.
>>
>> Acked-By: Himanshu Madhani <himanshu.madhani@qlogic.com>
>
>Actually, this isn't helpful. You now add another option over which the
>distributions have to make a choice. Is this interface necessary and
>useful? If yes, then it should be compiled in and if not, just remove
>it ... don't do death by 1000 Kconfig options.
I¹ll send out patch to clean up firmware binaries which are not submitted
to linux-firmware.git
>
>James
>
>
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 5458 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
2015-10-08 16:17 ` James Bottomley
2015-10-08 17:38 ` Himanshu Madhani
@ 2015-10-08 23:10 ` Julian Calaby
2015-10-09 0:26 ` Giridhar Malavali
1 sibling, 1 reply; 10+ messages in thread
From: Julian Calaby @ 2015-10-08 23:10 UTC (permalink / raw)
To: James Bottomley
Cc: Himanshu Madhani, Xose Vazquez Perez, Dept-Eng QLA2xxx Upstream,
linux-scsi, Linux Firmware Maintainers
Hi James,
On Fri, Oct 9, 2015 at 3:17 AM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Thu, 2015-10-08 at 15:46 +0000, Himanshu Madhani wrote:
>>
>> On 10/7/15, 4:41 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:
>>
>> >Hi Xose,
>> >
>> >On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez
>> ><xose.vazquez@gmail.com> wrote:
>> >> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby
>> >><julian.calaby@gmail.com> wrote:
>> >>
>> >>> Some qla2xxx devices have firmware stored in flash on the device,
>> >>> however for debugging and triage purposes, Qlogic staff like to
>> >>> be able to load known-good versions of these firmwares through
>> >>> request_firmware().
>> >>>
>> >>> These firmware files were never distributed and are unlikely to ever
>> >>> be released publically, so to hide these missing firmware files from
>> >>> scripts which check such things, (e.g. Debian's initramfs-tools) put
>> >>> them behind a new EXPERT Kconfig option.
>> >>
>> >>
>> >> What is state of this patch ?
>> >
>> >Apparently nobody cared, either from qLogic or linux-scsi.
>> >
>> >I'm not overly fussed whether it goes in or not, it was more a point
>> >in the discussion that proceeded it, however it does solve the
>> >problems in the discussion that preceded it.
>>
>> This patch Looks good.
>>
>> Acked-By: Himanshu Madhani <himanshu.madhani@qlogic.com>
>
> Actually, this isn't helpful. You now add another option over which the
> distributions have to make a choice. Is this interface necessary and
> useful? If yes, then it should be compiled in and if not, just remove
> it ... don't do death by 1000 Kconfig options.
The original issue here was that the qla2xxx driver specifies two
firmware files which are not publicly available.
They aren't publicly available because the hardware that uses them
always stores it's firmware in flash.
The firmware files are specified in the driver because qLogic support
likes to be able to load a known-good firmware file from disk for
debugging faulty hardware.
Some distributions (Debian is a good example) will complain vocally
about missing firmware files when installing kernels or producing
initramfs images.
This patch was intended as an ugly compromise between all of this.
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware
2015-10-08 23:10 ` Julian Calaby
@ 2015-10-09 0:26 ` Giridhar Malavali
2015-10-09 14:45 ` Xose Vazquez Perez
0 siblings, 1 reply; 10+ messages in thread
From: Giridhar Malavali @ 2015-10-09 0:26 UTC (permalink / raw)
To: Julian Calaby, James Bottomley
Cc: Himanshu Madhani, Xose Vazquez Perez, Dept-Eng QLA2xxx Upstream,
linux-scsi, Linux Firmware Maintainers
[-- Attachment #1: Type: text/plain, Size: 2693 bytes --]
On 10/8/15 4:10 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:
>Hi James,
>
>On Fri, Oct 9, 2015 at 3:17 AM, James Bottomley
><James.Bottomley@hansenpartnership.com> wrote:
>> On Thu, 2015-10-08 at 15:46 +0000, Himanshu Madhani wrote:
>>>
>>> On 10/7/15, 4:41 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote:
>>>
>>> >Hi Xose,
>>> >
>>> >On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez
>>> ><xose.vazquez@gmail.com> wrote:
>>> >> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby
>>> >><julian.calaby@gmail.com> wrote:
>>> >>
>>> >>> Some qla2xxx devices have firmware stored in flash on the device,
>>> >>> however for debugging and triage purposes, Qlogic staff like to
>>> >>> be able to load known-good versions of these firmwares through
>>> >>> request_firmware().
>>> >>>
>>> >>> These firmware files were never distributed and are unlikely to
>>>ever
>>> >>> be released publically, so to hide these missing firmware files
>>>from
>>> >>> scripts which check such things, (e.g. Debian's initramfs-tools)
>>>put
>>> >>> them behind a new EXPERT Kconfig option.
>>> >>
>>> >>
>>> >> What is state of this patch ?
>>> >
>>> >Apparently nobody cared, either from qLogic or linux-scsi.
>>> >
>>> >I'm not overly fussed whether it goes in or not, it was more a point
>>> >in the discussion that proceeded it, however it does solve the
>>> >problems in the discussion that preceded it.
>>>
>>> This patch Looks good.
>>>
>>> Acked-By: Himanshu Madhani <himanshu.madhani@qlogic.com>
>>
>> Actually, this isn't helpful. You now add another option over which the
>> distributions have to make a choice. Is this interface necessary and
>> useful? If yes, then it should be compiled in and if not, just remove
>> it ... don't do death by 1000 Kconfig options.
>
>The original issue here was that the qla2xxx driver specifies two
>firmware files which are not publicly available.
>
>They aren't publicly available because the hardware that uses them
>always stores it's firmware in flash.
>
>The firmware files are specified in the driver because qLogic support
>likes to be able to load a known-good firmware file from disk for
>debugging faulty hardware.
>
>Some distributions (Debian is a good example) will complain vocally
>about missing firmware files when installing kernels or producing
>initramfs images.
>
>This patch was intended as an ugly compromise between all of this.
Julian, James,
We will send a patch to remove such references in our driver.
-- Giri
>
>Thanks,
>
>--
>Julian Calaby
>
>Email: julian.calaby@gmail.com
>Profile: http://www.google.com/profiles/julian.calaby/
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 6142 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-10-09 14:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-22 0:00 [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware Julian Calaby
2015-05-22 0:05 ` Julian Calaby
2015-10-07 15:13 ` Xose Vazquez Perez
2015-10-07 23:41 ` Julian Calaby
2015-10-08 15:46 ` Himanshu Madhani
2015-10-08 16:17 ` James Bottomley
2015-10-08 17:38 ` Himanshu Madhani
2015-10-08 23:10 ` Julian Calaby
2015-10-09 0:26 ` Giridhar Malavali
2015-10-09 14:45 ` Xose Vazquez Perez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).