From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: don't try to load a device handler during async probing
Date: Mon, 12 Oct 2015 14:21:11 +0200 [thread overview]
Message-ID: <561BA5B7.8050703@suse.de> (raw)
In-Reply-To: <1444292732-8571-1-git-send-email-hch@lst.de>
On 10/08/2015 10:25 AM, Christoph Hellwig wrote:
> Request_module gets really unhappy when called from async probing, so
> revert to not auto load device handler modules during the SCSI bus
> scan. While autoloading would be really useful we never did this
> until 4.3-rc and it turns out that functionality doesn't actually
> work.
>
> Fixes: 566079 ("dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Paul Mackerras <paulus@ozlabs.org>
> Tested-by: Paul Mackerras <paulus@ozlabs.org>
> ---
> drivers/scsi/scsi_dh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
> index 0a2168e..d771bec 100644
> --- a/drivers/scsi/scsi_dh.c
> +++ b/drivers/scsi/scsi_dh.c
> @@ -226,7 +226,7 @@ int scsi_dh_add_device(struct scsi_device *sdev)
>
> drv = scsi_dh_find_driver(sdev);
> if (drv)
> - devinfo = scsi_dh_lookup(drv);
> + devinfo = __scsi_dh_lookup(drv);
> if (devinfo)
> err = scsi_dh_handler_attach(sdev, devinfo);
> return err;
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-10-12 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 8:25 [PATCH] scsi: don't try to load a device handler during async probing Christoph Hellwig
2015-10-12 12:21 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561BA5B7.8050703@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).