From: zhangfei <zhangfei.gao@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, John Garry <john.garry@huawei.com>
Cc: James.Bottomley@hansenpartnership.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linuxarm@huawei.com, linux-scsi@vger.kernel.org,
xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, hare@suse.de
Subject: Re: [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools
Date: Tue, 13 Oct 2015 17:42:19 +0800 [thread overview]
Message-ID: <561CD1FB.1060003@linaro.org> (raw)
In-Reply-To: <13409618.ra2GB8eyNb@wuerfel>
Hi, Arnd
On 10/12/2015 11:15 PM, Arnd Bergmann wrote:
> On Monday 12 October 2015 23:20:17 John Garry wrote:
>> + interrupt_count = of_property_count_u32_elems(np, "interrupts");
>> + if (interrupt_count < 0)
>> + goto err_out;
>> +
>> + if (of_property_read_u32(np, "#interrupt-cells", &interrupt_cells))
>> + goto err_out;
>> +
>> + hisi_hba->int_names = devm_kcalloc(&pdev->dev,
>> + interrupt_count / interrupt_cells,
>> + HISI_SAS_NAME_LEN,
>> + GFP_KERNEL);
>>
>
> This computation looks wrong: the "interrupts" property refers to interrupts
> that are referenced by this node and provided by an interrupt-controller,
> while the "#interrupt-cells" property refers to interrupts provided by
> this node. They don't need to have any relation.
>
We will use of_irq_count instead.
Thanks
next prev parent reply other threads:[~2015-10-13 9:42 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 15:20 [PATCH 00/25] HiSilicon SAS driver John Garry
2015-10-12 15:20 ` [PATCH 02/25] devicetree: bindings: scsi: HiSi SAS John Garry
2015-10-16 13:47 ` Rob Herring
[not found] ` <CAL_JsqLk9p_YX2FCNiR4sOSU74asN0UrOSJ5gQfnyRhrFH8LgQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-19 10:48 ` John Garry
2015-10-19 14:51 ` zhangfei
2015-10-12 15:20 ` [PATCH 03/25] scsi: hisi_sas: add initial bare driver John Garry
[not found] ` <1444663237-238302-4-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-15 8:49 ` Xinwei Kong
2015-10-15 9:23 ` John Garry
2015-10-15 9:28 ` zhangfei
[not found] ` <561F707C.1070305-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-15 12:07 ` Xinwei Kong
2015-10-12 15:20 ` [PATCH 04/25] scsi: hisi_sas: add scsi host registration John Garry
[not found] ` <1444663237-238302-5-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-12 15:21 ` Arnd Bergmann
2015-10-13 9:16 ` John Garry
2015-10-13 12:18 ` Arnd Bergmann
2015-10-12 15:20 ` [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW John Garry
2015-10-12 15:21 ` Arnd Bergmann
2015-10-13 9:47 ` zhangfei
[not found] ` <561CD316.6040406-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-13 12:20 ` Arnd Bergmann
2015-10-13 15:09 ` zhangfei
2015-10-12 17:18 ` kbuild test robot
2015-10-12 17:18 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_ioremap() can be static kbuild test robot
2015-10-12 15:20 ` [PATCH 08/25] scsi: hisi_sas: add cq structure initialization John Garry
2015-10-12 15:20 ` [PATCH 10/25] scsi: hisi_sas: add misc HBA initialization John Garry
2015-10-12 21:44 ` kbuild test robot
2015-10-12 15:20 ` [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code John Garry
2015-10-12 18:46 ` Arnd Bergmann
2015-10-13 12:44 ` John Garry
2015-10-13 12:47 ` Arnd Bergmann
2015-10-12 15:20 ` [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework John Garry
2015-10-12 22:03 ` kbuild test robot
2015-10-13 0:27 ` Julian Calaby
2015-10-13 0:40 ` [lkp] " Fengguang Wu
2015-10-12 22:03 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_bytes_dmaed() can be static kbuild test robot
2015-10-16 12:55 ` [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework Arnd Bergmann
2015-10-16 13:29 ` John Garry
2015-10-16 13:36 ` Arnd Bergmann
2015-10-19 14:11 ` John Garry
2015-10-19 14:26 ` Arnd Bergmann
2015-10-19 14:55 ` John Garry
2015-10-20 8:40 ` Arnd Bergmann
2015-10-20 9:09 ` John Garry
2015-10-12 15:20 ` [PATCH 15/25] scsi: hisi_sas: add cq interrupt handler John Garry
2015-10-12 22:15 ` kbuild test robot
2015-10-12 15:20 ` [PATCH 16/25] scsi: hisi_sas: add dev_found and port_formed John Garry
2015-10-12 22:35 ` kbuild test robot
2015-10-12 22:35 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_alloc_dev() can be static kbuild test robot
2015-10-12 15:20 ` [PATCH 17/25] scsi: hisi_sas: add abnormal irq handler John Garry
2015-10-12 15:20 ` [PATCH 18/25] scsi: hisi_sas: add dev_gone and port_deformed John Garry
2015-10-12 22:49 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_do_release_task() can be static kbuild test robot
[not found] ` <1444663237-238302-19-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-12 22:49 ` [PATCH 18/25] scsi: hisi_sas: add dev_gone and port_deformed kbuild test robot
2015-10-12 15:20 ` [PATCH 19/25] scsi: hisi_sas: add bcast interrupt handler John Garry
[not found] ` <1444663237-238302-1-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-12 15:20 ` [PATCH 01/25] [SCSI] sas: centralise ssp frame information units John Garry
2015-10-12 15:20 ` [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools John Garry
[not found] ` <1444663237-238302-6-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-12 15:15 ` Arnd Bergmann
2015-10-13 9:42 ` zhangfei [this message]
2015-10-13 1:05 ` kbuild test robot
2015-10-12 15:20 ` [PATCH 06/25] scsi: hisi_sas: add slot init code John Garry
2015-10-12 15:20 ` [PATCH 09/25] scsi: hisi_sas: add phy SAS ADDR initialization John Garry
2015-10-13 6:12 ` Hannes Reinecke
[not found] ` <561CA0CB.5090802-l3A5Bk7waGM@public.gmane.org>
2015-10-13 17:14 ` John Garry
2015-10-14 8:40 ` Hannes Reinecke
[not found] ` <561E1501.2070507-l3A5Bk7waGM@public.gmane.org>
2015-10-14 15:05 ` John Garry
2015-10-14 15:18 ` Arnd Bergmann
2015-10-15 3:36 ` zhangfei
2015-10-15 8:43 ` Arnd Bergmann
2015-10-12 15:20 ` [PATCH 11/25] scsi: hisi_sas: add v1 hardware register definitions John Garry
2015-10-12 15:20 ` [PATCH 14/25] scsi: hisi_sas: add ssp command function John Garry
2015-10-13 1:24 ` kbuild test robot
2015-10-12 15:20 ` [PATCH 20/25] scsi: hisi_sas: add smp protocol support John Garry
2015-10-12 15:20 ` [PATCH 22/25] scsi: hisi_sas: add tmf methods John Garry
2015-10-12 23:02 ` kbuild test robot
[not found] ` <1444663237-238302-23-git-send-email-john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-10-12 23:02 ` [RFC PATCH] scsi: hisi_sas: hisi_sas_find_dev_phyno() can be static kbuild test robot
2015-10-12 15:20 ` [PATCH 23/25] scsi: hisi_sas: add control phy handler John Garry
2015-10-19 8:47 ` [PATCH 00/25] HiSilicon SAS driver John Garry
2015-10-19 8:55 ` Hannes Reinecke
[not found] ` <5624B015.3000603-l3A5Bk7waGM@public.gmane.org>
2015-10-19 10:40 ` John Garry
2015-10-12 15:20 ` [PATCH 21/25] scsi: hisi_sas: add scan finished and start John Garry
2015-10-12 15:20 ` [PATCH 24/25] scsi: hisi_sas: add fatal irq handler John Garry
2015-10-12 15:20 ` [PATCH 25/25] MAINTAINERS: add maintainer for HiSi SAS driver John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561CD1FB.1060003@linaro.org \
--to=zhangfei.gao@linaro.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=hare@suse.de \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).