From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangfei Subject: Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW Date: Tue, 13 Oct 2015 17:47:02 +0800 Message-ID: <561CD316.6040406@linaro.org> References: <1444663237-238302-1-git-send-email-john.garry@huawei.com> <1444663237-238302-8-git-send-email-john.garry@huawei.com> <5285087.C8umupFr76@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5285087.C8umupFr76@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann , John Garry Cc: James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, john.garry2-s/0ZXS5h9803lw97EnAbAg@public.gmane.org, hare-l3A5Bk7waGM@public.gmane.org List-Id: linux-scsi@vger.kernel.org On 10/12/2015 11:21 PM, Arnd Bergmann wrote: > On Monday 12 October 2015 23:20:19 John Garry wrote: >> +int hisi_sas_ioremap(struct hisi_hba *hisi_hba) >> +{ >> + struct platform_device *pdev = hisi_hba->pdev; >> + struct device *dev = &pdev->dev; >> + struct resource *res; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + hisi_hba->regs = devm_ioremap(dev, >> + res->start, >> + resource_size(res)); >> + if (!hisi_hba->regs) >> + return -ENOMEM; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); >> + hisi_hba->ctrl_regs = devm_ioremap(dev, >> + res->start, >> + resource_size(res)); >> + if (!hisi_hba->ctrl_regs) >> + return -ENOMEM; >> + >> + return 0; >> +} >> >> static const struct of_device_id sas_of_match[] = { >> > > Better use devm_ioremap_resource() here, which registers the resource so they > are checked for conflicts and listed in /proc/iomem. > Yes, hisi_hba->regs can use devm_ioremap_resource. However ctrl_regs have to use devm_ioremap, since the address are sharing among different nodes, unfortunately, and devm_ioremap_resource will fail. Thanks -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html