SSP frame iu defines

SSP frame iu defines

[John Garry]

Hi,

For a new driver I am preparing for a SAS controller, I need defintions 
for the SSP command and TMF iu structures. Currently these are defined 
in the following:
ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h
ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h

I plan to move them to include/scsi/sas.h . Any objections?

Thanks,
John

Re: SSP frame iu defines

[Arnd Bergmann]

On Thursday 08 October 2015 15:17:49 John Garry wrote:
> Hi,
> 
> For a new driver I am preparing for a SAS controller, I need defintions 
> for the SSP command and TMF iu structures. Currently these are defined 
> in the following:
> ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h
> ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h
> 
> I plan to move them to include/scsi/sas.h . Any objections?

Hi John,

I think a question like this is better asked by sending a patch,
to make it easier to see what the resulting change is.

	Arnd

Re: SSP frame iu defines

[John Garry]

On 08/10/2015 15:22, Arnd Bergmann wrote:
> On Thursday 08 October 2015 15:17:49 John Garry wrote:
>> Hi,
>>
>> For a new driver I am preparing for a SAS controller, I need defintions
>> for the SSP command and TMF iu structures. Currently these are defined
>> in the following:
>> ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h
>> ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h
>>
>> I plan to move them to include/scsi/sas.h . Any objections?
>
> Hi John,
>
> I think a question like this is better asked by sending a patch,
> to make it easier to see what the resulting change is.
>
> 	Arnd
>
>
OK, can I put this together.
I feel that the code may get messy due to byte-ordering difference in 
isci versions.

Regards,
John

Re: SSP frame iu defines

[Hannes Reinecke]

On 10/08/2015 04:47 PM, John Garry wrote:
> On 08/10/2015 15:22, Arnd Bergmann wrote:
>> On Thursday 08 October 2015 15:17:49 John Garry wrote:
>>> Hi,
>>>
>>> For a new driver I am preparing for a SAS controller, I need
>>> defintions
>>> for the SSP command and TMF iu structures. Currently these are
>>> defined
>>> in the following:
>>> ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h
>>> ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h
>>>
>>> I plan to move them to include/scsi/sas.h . Any objections?
>>
>> Hi John,
>>
>> I think a question like this is better asked by sending a patch,
>> to make it easier to see what the resulting change is.
>>
>>     Arnd
>>
>>
> OK, can I put this together.
> I feel that the code may get messy due to byte-ordering difference
> in isci versions.
> 
Then define a standard version, and use the appropriate conversion
macros in the driver itself.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: SSP frame iu defines

[James Bottomley]

On Thu, 2015-10-08 at 15:47 +0100, John Garry wrote:
> On 08/10/2015 15:22, Arnd Bergmann wrote:
> > On Thursday 08 October 2015 15:17:49 John Garry wrote:
> >> Hi,
> >>
> >> For a new driver I am preparing for a SAS controller, I need defintions
> >> for the SSP command and TMF iu structures. Currently these are defined
> >> in the following:
> >> ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h
> >> ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h
> >>
> >> I plan to move them to include/scsi/sas.h . Any objections?
> >
> > Hi John,
> >
> > I think a question like this is better asked by sending a patch,
> > to make it easier to see what the resulting change is.
> >
> > 	Arnd
> >
> >
> OK, can I put this together.
> I feel that the code may get messy due to byte-ordering difference in 
> isci versions.

That's why we develop with the show me the code model.  Rather than
arguing theoretically about whether something should or should not be
done, you propose the actual change.  If it looks like a dog's breakfast
and all attempts to clean it up fail, chances are it's a bad change and
it won't go in.  However, if it looks good, chances are it will.

James

Re: SSP frame iu defines

[John Garry]

>> OK, can I put this together.
>> I feel that the code may get messy due to byte-ordering difference in
>> isci versions.
>
> That's why we develop with the show me the code model.  Rather than
> arguing theoretically about whether something should or should not be
> done, you propose the actual change.  If it looks like a dog's breakfast
> and all attempts to clean it up fail, chances are it's a bad change and
> it won't go in.  However, if it looks good, chances are it will.
>
> James
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> .
>

There is a patch for this in "[PATCH 01/25] [SCSI] sas: centralise ssp 
frame information units".

Thanks,
John