* [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally
@ 2015-10-15 8:09 sumit.saxena
2015-10-16 14:26 ` Tomas Henzl
2015-10-28 2:13 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: sumit.saxena @ 2015-10-15 8:09 UTC (permalink / raw)
To: linux-scsi, stable, thenzl, martin.petersen, hch, jbottomley,
kashyap.desai, sumit.saxena, kiran-kumar.kasturi
Cc: uday.lingala
Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue is reported in Redhat Bugzilla [Bug 1254762].
Cc: <stable@vger.kernel.org>
Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index d2ebcdd..d00d494 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -1743,8 +1743,9 @@ static int megasas_slave_alloc(struct scsi_device *sdev)
pd_index =
(sdev->channel * MEGASAS_MAX_DEV_PER_CHANNEL) +
sdev->id;
- if (instance->pd_list[pd_index].driveState ==
- MR_PD_STATE_SYSTEM) {
+ if ((instance->pd_list[pd_index].driveState ==
+ MR_PD_STATE_SYSTEM) ||
+ (instance->pd_list[pd_index].driveType != TYPE_DISK)) {
return 0;
}
return -ENXIO;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally
2015-10-15 8:09 [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally sumit.saxena
@ 2015-10-16 14:26 ` Tomas Henzl
2015-10-28 2:13 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Tomas Henzl @ 2015-10-16 14:26 UTC (permalink / raw)
To: sumit.saxena, linux-scsi, stable, martin.petersen, hch,
jbottomley, kashyap.desai, kiran-kumar.kasturi
Cc: uday.lingala
On 15.10.2015 10:09, sumit.saxena@avagotech.com wrote:
> Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue is reported in Redhat Bugzilla [Bug 1254762].
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
> Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally
2015-10-15 8:09 [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally sumit.saxena
2015-10-16 14:26 ` Tomas Henzl
@ 2015-10-28 2:13 ` Martin K. Petersen
2015-10-28 10:58 ` Sumit Saxena
1 sibling, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2015-10-28 2:13 UTC (permalink / raw)
To: sumit.saxena
Cc: linux-scsi, stable, thenzl, martin.petersen, hch, jbottomley,
kashyap.desai, kiran-kumar.kasturi, uday.lingala
Sumit> Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue
Sumit> is reported in Redhat Bugzilla [Bug 1254762].
RH bugzilla is not public so I removed this blurb from the patch
description.
In the future, please drop the spaces after megaraid_sas in patch
header. I fixed those up for now.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally
2015-10-28 2:13 ` Martin K. Petersen
@ 2015-10-28 10:58 ` Sumit Saxena
0 siblings, 0 replies; 4+ messages in thread
From: Sumit Saxena @ 2015-10-28 10:58 UTC (permalink / raw)
To: Martin K. Petersen
Cc: linux-scsi, stable, thenzl, hch, jbottomley, Kashyap Desai,
Kiran Kumar Kasturi, Uday Lingala
> -----Original Message-----
> From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
> Sent: Wednesday, October 28, 2015 7:44 AM
> To: sumit.saxena@avagotech.com
> Cc: linux-scsi@vger.kernel.org; stable@vger.kernel.org;
thenzl@redhat.com;
> martin.petersen@oracle.com; hch@infradead.org; jbottomley@parallels.com;
> kashyap.desai@avagotech.com; kiran-kumar.kasturi@avagotech.com;
> uday.lingala@avagotech.com
> Subject: Re: [PATCH 01/12] megaraid_sas : Expose TAPE drives
unconditionally
>
>
> Sumit> Expose non-disk(TAPE drive, CD-ROM) unconditionally. This issue
> Sumit> is reported in Redhat Bugzilla [Bug 1254762].
>
> RH bugzilla is not public so I removed this blurb from the patch
description.
>
> In the future, please drop the spaces after megaraid_sas in patch
header. I fixed
> those up for now.
Sure, I will take care of it while sending patches in future.
Thanks,
Sumit
>
> --
> Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-28 10:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 8:09 [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally sumit.saxena
2015-10-16 14:26 ` Tomas Henzl
2015-10-28 2:13 ` Martin K. Petersen
2015-10-28 10:58 ` Sumit Saxena
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).