From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [PATCH v6 21/37] cxlflash: Correct behavior in device reset handler following EEH Date: Fri, 23 Oct 2015 15:42:01 +0200 Message-ID: <562A3929.2070608@redhat.com> References: <1445458134-63197-1-git-send-email-mrochs@linux.vnet.ibm.com> <1445458464-40183-1-git-send-email-mrochs@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42335 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752443AbbJWNmF (ORCPT ); Fri, 23 Oct 2015 09:42:05 -0400 In-Reply-To: <1445458464-40183-1-git-send-email-mrochs@linux.vnet.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Matthew R. Ochs" , linux-scsi@vger.kernel.org, James Bottomley , "Nicholas A. Bellinger" , Brian King , Ian Munsie , Daniel Axtens , Andrew Donnellan , David Laight Cc: Michael Neuling , "Manoj N. Kumar" , linuxppc-dev@lists.ozlabs.org On 21.10.2015 22:14, Matthew R. Ochs wrote: > When the device reset handler is entered while a reset operation > is taking place, the handler exits without actually sending a > reset (TMF) to the targeted device. This behavior is incorrect > as the device is not reset. Further complicating matters is the > fact that a success is returned even when the TMF was not sent. > > To fix, the state is rechecked after coming out of the reset > state. When the state is normal, a TMF will be sent out. > > Signed-off-by: Matthew R. Ochs > Signed-off-by: Manoj N. Kumar > Reviewed-by: Brian King Reviewed-by: Tomas Henzl Tomas