* Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
2015-10-26 14:54 [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Peter Oberparleiter
@ 2015-10-27 1:56 ` Bart Van Assche
2015-10-27 6:57 ` Hannes Reinecke
2015-10-27 16:12 ` Ewan Milne
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2015-10-27 1:56 UTC (permalink / raw)
To: Peter Oberparleiter, James E.J. Bottomley; +Cc: linux-scsi, linux-kernel
On 10/26/15 07:54, Peter Oberparleiter wrote:
> Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
> returns the value of that number instead of the number of bytes written.
> This behavior can confuse programs expecting POSIX write() semantics.
> Fix this by returning the number of bytes written instead.
>
> Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> ---
> drivers/scsi/scsi_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index b333389..6b0f292 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
> return -EINVAL;
>
> sdev->queue_ramp_up_period = msecs_to_jiffies(period);
> - return period;
> + return count;
> }
>
> static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
Hello Peter,
Good catch. But please CC the people who introduced this code and also
"stable" (see also commit 4a84067dbfce436b81779e585bf712b02ceee552).
Thanks,
Bart.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
2015-10-26 14:54 [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Peter Oberparleiter
2015-10-27 1:56 ` Bart Van Assche
@ 2015-10-27 6:57 ` Hannes Reinecke
2015-10-27 16:12 ` Ewan Milne
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2015-10-27 6:57 UTC (permalink / raw)
To: Peter Oberparleiter, James E.J. Bottomley; +Cc: linux-scsi, linux-kernel
On 10/26/2015 03:54 PM, Peter Oberparleiter wrote:
> Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
> returns the value of that number instead of the number of bytes written.
> This behavior can confuse programs expecting POSIX write() semantics.
> Fix this by returning the number of bytes written instead.
>
> Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> ---
> drivers/scsi/scsi_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index b333389..6b0f292 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
> return -EINVAL;
>
> sdev->queue_ramp_up_period = msecs_to_jiffies(period);
> - return period;
> + return count;
> }
>
> static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
2015-10-26 14:54 [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Peter Oberparleiter
2015-10-27 1:56 ` Bart Van Assche
2015-10-27 6:57 ` Hannes Reinecke
@ 2015-10-27 16:12 ` Ewan Milne
2 siblings, 0 replies; 4+ messages in thread
From: Ewan Milne @ 2015-10-27 16:12 UTC (permalink / raw)
To: Peter Oberparleiter; +Cc: James E.J. Bottomley, linux-scsi, linux-kernel
On Mon, 2015-10-26 at 15:54 +0100, Peter Oberparleiter wrote:
> Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
> returns the value of that number instead of the number of bytes written.
> This behavior can confuse programs expecting POSIX write() semantics.
> Fix this by returning the number of bytes written instead.
>
> Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> ---
> drivers/scsi/scsi_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index b333389..6b0f292 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
> return -EINVAL;
>
> sdev->queue_ramp_up_period = msecs_to_jiffies(period);
> - return period;
> + return count;
> }
>
> static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread