From: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
To: "James E.J. Bottomley" <JBottomley@odin.com>
Cc: Vasu Dev <vasu.dev@intel.com>,
stable@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
Date: Tue, 27 Oct 2015 10:49:54 +0100 [thread overview]
Message-ID: <562F48C2.1070803@linux.vnet.ibm.com> (raw)
Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
returns the value of that number instead of the number of bytes written.
This behavior can confuse programs expecting POSIX write() semantics.
Fix this by returning the number of bytes written instead.
Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: stable@vger.kernel.org
---
drivers/scsi/scsi_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index b333389..6b0f292 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
return -EINVAL;
sdev->queue_ramp_up_period = msecs_to_jiffies(period);
- return period;
+ return count;
}
static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
--
2.3.0
next reply other threads:[~2015-10-27 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 9:49 Peter Oberparleiter [this message]
2015-10-28 22:12 ` [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Matthew R. Ochs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F48C2.1070803@linux.vnet.ibm.com \
--to=oberpar@linux.vnet.ibm.com \
--cc=JBottomley@odin.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vasu.dev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).