* [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
@ 2015-10-27 9:49 Peter Oberparleiter
2015-10-28 22:12 ` Matthew R. Ochs
0 siblings, 1 reply; 2+ messages in thread
From: Peter Oberparleiter @ 2015-10-27 9:49 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Vasu Dev, stable, linux-scsi, linux-kernel, Hannes Reinecke,
Bart Van Assche
Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
returns the value of that number instead of the number of bytes written.
This behavior can confuse programs expecting POSIX write() semantics.
Fix this by returning the number of bytes written instead.
Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: stable@vger.kernel.org
---
drivers/scsi/scsi_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index b333389..6b0f292 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
return -EINVAL;
sdev->queue_ramp_up_period = msecs_to_jiffies(period);
- return period;
+ return count;
}
static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
--
2.3.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
2015-10-27 9:49 [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Peter Oberparleiter
@ 2015-10-28 22:12 ` Matthew R. Ochs
0 siblings, 0 replies; 2+ messages in thread
From: Matthew R. Ochs @ 2015-10-28 22:12 UTC (permalink / raw)
To: Peter Oberparleiter
Cc: James E.J. Bottomley, Vasu Dev, stable, linux-scsi, linux-kernel,
Hannes Reinecke, Bart Van Assche
> On Oct 27, 2015, at 4:49 AM, Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote:
>
> Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
> returns the value of that number instead of the number of bytes written.
> This behavior can confuse programs expecting POSIX write() semantics.
> Fix this by returning the number of bytes written instead.
>
> Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Cc: stable@vger.kernel.org
> ---
> drivers/scsi/scsi_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index b333389..6b0f292 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
> return -EINVAL;
>
> sdev->queue_ramp_up_period = msecs_to_jiffies(period);
> - return period;
> + return count;
> }
>
> static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-28 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-27 9:49 [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Peter Oberparleiter
2015-10-28 22:12 ` Matthew R. Ochs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).