Re: [PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN

[Laurent Vivier <lvivier@redhat.com>]

On 09/11/2015 15:04, Hannes Reinecke wrote:
> On 11/09/2015 02:53 PM, Laurent Vivier wrote:
>> QEMU allows until 32 LUNs.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>>  drivers/scsi/ibmvscsi/ibmvscsi.c | 9 ++++++++-
>>  drivers/scsi/ibmvscsi/ibmvscsi.h | 1 +
>>  2 files changed, 9 insertions(+), 1 deletion(-)
>>
> Nothing to do with QEMU; this is a driver limitation.
> Please fixup the description.

Yes, you're right, and I think I didn't define correctly the maximum
value, I use 31 instead of 32 as explained in include/scsi/scsi_host.h:

        /*
         * These three parameters can be used to allow for wide scsi,
         * and for host adapters that support multiple busses
         * The last two should be set to 1 more than the actual max id
         * or lun (e.g. 8 for SCSI parallel systems).
         */
        unsigned int max_channel;
        unsigned int max_id;
        u64 max_lun;

Laurent