From: Douglas Gilbert <dgilbert@interlog.com>
To: "Martin K. Petersen" <martin.petersen@ORACLE.COM>,
"James E.J. Bottomley" <jbottomley@odin.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Cc: sweet_f_a@gmx.de, util-linux@vger.kernel.org
Subject: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions
Date: Sun, 22 Nov 2015 12:11:28 -0500 [thread overview]
Message-ID: <5651F740.3010707@interlog.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Ruediger Meier observed a regression with the PREVENT ALLOW
MEDIUM REMOVAL command in lk 3.19:
http://www.spinics.net/lists/util-linux-ng/msg11448.html
Inspection indicated the same regression with VERIFY(10).
The patch is against lk 3.19.3 and also works with lk 4.3.0 .
With this patch both commands are accepted and do nothing.
ChangeLog:
- fix the lk 3.19 regression so that the PREVENT ALLOW
MEDIUM REMOVAL command is supported once again
- same fix for VERIFY(10)
Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
[-- Attachment #2: sdebug319regr1.patch --]
[-- Type: text/x-patch, Size: 1399 bytes --]
--- a/drivers/scsi/scsi_debug.c 2015-02-11 17:47:09.276206425 -0500
+++ b/drivers/scsi/scsi_debug.c 2015-04-03 22:42:36.343971372 -0400
@@ -455,8 +455,9 @@ static const struct opcode_info_t opcode
0} },
{0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* MAINT OUT */
{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
- {0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* VERIFY */
- {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
+ {0, 0x2f, 0, F_D_OUT_MAYBE | FF_DIRECT_IO, NULL, NULL, /* VERIFY(10) */
+ {10, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xc7,
+ 0, 0, 0, 0, 0, 0} },
{1, 0x7f, 0x9, F_SA_HIGH | F_D_IN | FF_DIRECT_IO, resp_read_dt0,
vl_iarr, {32, 0xc7, 0, 0, 0, 0, 0x1f, 0x18, 0x0, 0x9, 0xfe, 0,
0xff, 0xff, 0xff, 0xff} },/* VARIABLE LENGTH, READ(32) */
@@ -467,8 +468,8 @@ static const struct opcode_info_t opcode
{10, 0x13, 0xff, 0xff, 0, 0, 0, 0xff, 0xff, 0xc7, 0, 0, 0, 0, 0,
0} },
/* 20 */
- {0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* ALLOW REMOVAL */
- {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
+ {0, 0x1e, 0, 0, NULL, NULL, /* ALLOW REMOVAL */
+ {6, 0, 0, 0, 0x3, 0xc7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
{0, 0x1, 0, 0, resp_start_stop, NULL, /* REWIND ?? */
{6, 0x1, 0, 0, 0, 0xc7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} },
{0, 0, 0, F_INV_OP | FF_RESPOND, NULL, NULL, /* ATA_PT */
next reply other threads:[~2015-11-22 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 17:11 Douglas Gilbert [this message]
[not found] ` <5651F740.3010707-qazKcTl6WRFWk0Htik3J/w@public.gmane.org>
2015-11-24 15:04 ` [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions Hannes Reinecke
2015-11-24 15:25 ` Ewan Milne
2015-11-24 20:25 ` Martin K. Petersen
[not found] ` <yq1k2p7kuvd.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2015-11-25 20:51 ` Andy Shevchenko
[not found] ` <CAHp75VfpMdjmoipaJg7f4fR=6Mbyf1J_qmdoRm=zJ1ZWUW8EwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-26 2:14 ` Martin K. Petersen
[not found] ` <yq1fuztjymb.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2015-11-27 9:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5651F740.3010707@interlog.com \
--to=dgilbert@interlog.com \
--cc=jbottomley@odin.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@ORACLE.COM \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).