From: Arnd Bergmann <arnd@arndb.de>
To: Tina Ruchandani <ruchandani.tina@gmail.com>
Cc: linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [PATCH] [SCSI] mvumi: 64bit value for seconds_since1970
Date: Wed, 25 Feb 2015 11:48:33 +0100 [thread overview]
Message-ID: <5652033.yqM2roEabN@wuerfel> (raw)
In-Reply-To: <20150225021354.GA2794@tinar>
On Wednesday 25 February 2015 07:43:54 Tina Ruchandani wrote:
> struct mvumi_hs_page2 stores a "seconds_since1970" field which is of
> type u64. It is however, written to, using 'struct timeval' which has
> a 32-bit seconds field and whose value will overflow in year 2038.
> This patch uses ktime_get_real_seconds() instead since it provides a
> 64-bit seconds value, which is 2038 safe.
>
> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I note that in this case, the bug exists and is fixed by your patch
on both 32-bit and 64-bit kernels.
I am unsure whether it is correct that this driver along with 3w-9xxx.c
and 3w-sas.c, but unlike all others, uses local time instead of UTC,
but your patch does not change that.
prev parent reply other threads:[~2015-02-25 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 2:13 [PATCH] [SCSI] mvumi: 64bit value for seconds_since1970 Tina Ruchandani
2015-02-25 10:48 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652033.yqM2roEabN@wuerfel \
--to=arnd@arndb.de \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ruchandani.tina@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox