Re: [PATCH 05/20] qla2xxx: Added interface to send ELS commands from driver.

Hannes Reinecke
2015-12-08T15:54:53Z

On 12/08/2015 01:48 AM, Himanshu Madhani wrote:
> Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
> ---
> drivers/scsi/qla2xxx/qla_attr.c | 36 +++++++
> drivers/scsi/qla2xxx/qla_dbg.c | 5 +-
> drivers/scsi/qla2xxx/qla_def.h | 19 ++++-
> drivers/scsi/qla2xxx/qla_gbl.h | 2 +
> drivers/scsi/qla2xxx/qla_inline.h | 2 +
> drivers/scsi/qla2xxx/qla_iocb.c | 189 +++++++++++++++++++++++++++++++++++++
> drivers/scsi/qla2xxx/qla_isr.c | 6 +
> 7 files changed, 255 insertions(+), 4 deletions(-)
>
Well, this isn't actually an interface to send generic ELS commands,
it's an interface to send an explicit LOGO using ELS.
Personally, I'd prefer to have a 'real' ELS interface using bsg,
and map the explicit LOGO based on that.

Alternatively please fixup the description.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)