From: Hannes Reinecke <hare@suse.de>
To: James Smart <james.smart@avagotech.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 03/17] lpfc: Added throttle logging support.
Date: Thu, 17 Dec 2015 09:14:51 +0100 [thread overview]
Message-ID: <56726EFB.5060707@suse.de> (raw)
In-Reply-To: <5671efba.8C/kxNA2eqfImskd%james.smart@avagotech.com>
On 12/17/2015 12:11 AM, James Smart wrote:
>
> Implemented a throttle on error logging.
>
> Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> ---
> drivers/scsi/lpfc/lpfc.h | 5 +++
> drivers/scsi/lpfc/lpfc_attr.c | 18 +++++++++++
> drivers/scsi/lpfc/lpfc_crtn.h | 1 +
> drivers/scsi/lpfc/lpfc_disc.h | 11 +++++++
> drivers/scsi/lpfc/lpfc_hbadisc.c | 23 +++++++++++++
> drivers/scsi/lpfc/lpfc_init.c | 70 ++++++++++++++++++++++++++++++++++++++++
> drivers/scsi/lpfc/lpfc_logmsg.h | 40 +++++++++++++++++++++++
> drivers/scsi/lpfc/lpfc_scsi.c | 41 ++++++++++++++++-------
> drivers/scsi/lpfc/lpfc_sli.c | 7 ++++
> 9 files changed, 205 insertions(+), 11 deletions(-)
>
Weeellll ... that stuff doesn't really belong into the driver.
_If_ that really is an issue it should be moved into a generic
helper, as other drivers will have the same problem.
There also have been quite some discussions at KS about how to
handle high-volume logging traffic; also systemd implements its own
handling, too.
So it really needs to be discussed separately, and not implemented
within a driver.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-17 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 23:11 [PATCH 03/17] lpfc: Added throttle logging support James Smart
2015-12-17 8:14 ` Hannes Reinecke [this message]
2015-12-17 15:57 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56726EFB.5060707@suse.de \
--to=hare@suse.de \
--cc=james.smart@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).