linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 08/17] lpfc: Fix RDP Speed reporting.
@ 2015-12-16 23:11 James Smart
  2015-12-17  8:25 ` Hannes Reinecke
  0 siblings, 1 reply; 4+ messages in thread
From: James Smart @ 2015-12-16 23:11 UTC (permalink / raw)
  To: linux-scsi


Fix RDP Speed reporting.

Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
---
 drivers/scsi/lpfc/lpfc_els.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 3394648..f7a2967 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4730,28 +4730,25 @@ lpfc_rdp_res_speed(struct fc_rdp_port_speed_desc *desc, struct lpfc_hba *phba)
 
 	desc->tag = cpu_to_be32(RDP_PORT_SPEED_DESC_TAG);
 
-	switch (phba->sli4_hba.link_state.speed) {
-	case LPFC_FC_LA_SPEED_1G:
+	switch (phba->fc_linkspeed) {
+	case LPFC_LINK_SPEED_1GHZ:
 		rdp_speed = RDP_PS_1GB;
 		break;
-	case LPFC_FC_LA_SPEED_2G:
+	case LPFC_LINK_SPEED_2GHZ:
 		rdp_speed = RDP_PS_2GB;
 		break;
-	case LPFC_FC_LA_SPEED_4G:
+	case LPFC_LINK_SPEED_4GHZ:
 		rdp_speed = RDP_PS_4GB;
 		break;
-	case LPFC_FC_LA_SPEED_8G:
+	case LPFC_LINK_SPEED_8GHZ:
 		rdp_speed = RDP_PS_8GB;
 		break;
-	case LPFC_FC_LA_SPEED_10G:
+	case LPFC_LINK_SPEED_10GHZ:
 		rdp_speed = RDP_PS_10GB;
 		break;
-	case LPFC_FC_LA_SPEED_16G:
+	case LPFC_LINK_SPEED_16GHZ:
 		rdp_speed = RDP_PS_16GB;
 		break;
-	case LPFC_FC_LA_SPEED_32G:
-		rdp_speed = RDP_PS_32GB;
-		break;
 	default:
 		rdp_speed = RDP_PS_UNKNOWN;
 		break;
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 08/17] lpfc: Fix RDP Speed reporting.
  2015-12-16 23:11 [PATCH 08/17] lpfc: Fix RDP Speed reporting James Smart
@ 2015-12-17  8:25 ` Hannes Reinecke
  2015-12-17 15:47   ` James Smart
  0 siblings, 1 reply; 4+ messages in thread
From: Hannes Reinecke @ 2015-12-17  8:25 UTC (permalink / raw)
  To: James Smart, linux-scsi

On 12/17/2015 12:11 AM, James Smart wrote:
>
> Fix RDP Speed reporting.
>
> Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> ---
>   drivers/scsi/lpfc/lpfc_els.c | 17 +++++++----------
>   1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 3394648..f7a2967 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4730,28 +4730,25 @@ lpfc_rdp_res_speed(struct fc_rdp_port_speed_desc *desc, struct lpfc_hba *phba)
>
>   	desc->tag = cpu_to_be32(RDP_PORT_SPEED_DESC_TAG);
>
> -	switch (phba->sli4_hba.link_state.speed) {
> -	case LPFC_FC_LA_SPEED_1G:
> +	switch (phba->fc_linkspeed) {
> +	case LPFC_LINK_SPEED_1GHZ:
>   		rdp_speed = RDP_PS_1GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_2G:
> +	case LPFC_LINK_SPEED_2GHZ:
>   		rdp_speed = RDP_PS_2GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_4G:
> +	case LPFC_LINK_SPEED_4GHZ:
>   		rdp_speed = RDP_PS_4GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_8G:
> +	case LPFC_LINK_SPEED_8GHZ:
>   		rdp_speed = RDP_PS_8GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_10G:
> +	case LPFC_LINK_SPEED_10GHZ:
>   		rdp_speed = RDP_PS_10GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_16G:
> +	case LPFC_LINK_SPEED_16GHZ:
>   		rdp_speed = RDP_PS_16GB;
>   		break;
> -	case LPFC_FC_LA_SPEED_32G:
> -		rdp_speed = RDP_PS_32GB;
> -		break;
>   	default:
>   		rdp_speed = RDP_PS_UNKNOWN;
>   		break;
>
What happened to 32G? Has development ceased on that?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 08/17] lpfc: Fix RDP Speed reporting.
  2015-12-17  8:25 ` Hannes Reinecke
@ 2015-12-17 15:47   ` James Smart
  2015-12-17 16:04     ` Hannes Reinecke
  0 siblings, 1 reply; 4+ messages in thread
From: James Smart @ 2015-12-17 15:47 UTC (permalink / raw)
  To: Hannes Reinecke, linux-scsi

See patch 11/17 for the 32G additions

-- james s

On 12/17/2015 12:25 AM, Hannes Reinecke wrote:
> What happened to 32G? Has development ceased on that?
>
> Cheers,
>
> Hannes


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 08/17] lpfc: Fix RDP Speed reporting.
  2015-12-17 15:47   ` James Smart
@ 2015-12-17 16:04     ` Hannes Reinecke
  0 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2015-12-17 16:04 UTC (permalink / raw)
  To: James Smart; +Cc: linux-scsi

On Thursday, December 17, 2015 07:47:46 AM James Smart wrote:
> See patch 11/17 for the 32G additions
> 
Right.

Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		 zSeries & Storage
hare@suse.de		+49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-12-17 16:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-16 23:11 [PATCH 08/17] lpfc: Fix RDP Speed reporting James Smart
2015-12-17  8:25 ` Hannes Reinecke
2015-12-17 15:47   ` James Smart
2015-12-17 16:04     ` Hannes Reinecke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).