From: James Smart <james.smart@avagotech.com>
To: Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 03/17] lpfc: Added throttle logging support.
Date: Thu, 17 Dec 2015 07:57:08 -0800 [thread overview]
Message-ID: <5672DB54.2090803@avagotech.com> (raw)
In-Reply-To: <56726EFB.5060707@suse.de>
The real issue is when extended logging is turned on, which is not there
by default, then it definitely can become a problem. I don't doubt
other drivers hit it too.
I can understand solving this generically and I'm sure there's much
better people than I to solve the issue at the kernel level.
-- james s
On 12/17/2015 12:14 AM, Hannes Reinecke wrote:
> On 12/17/2015 12:11 AM, James Smart wrote:
>>
>> Implemented a throttle on error logging.
>>
> Weeellll ... that stuff doesn't really belong into the driver.
>
> _If_ that really is an issue it should be moved into a generic helper,
> as other drivers will have the same problem.
> There also have been quite some discussions at KS about how to handle
> high-volume logging traffic; also systemd implements its own handling,
> too.
>
> So it really needs to be discussed separately, and not implemented
> within a driver.
>
> Cheers,
>
> Hannes
prev parent reply other threads:[~2015-12-17 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 23:11 [PATCH 03/17] lpfc: Added throttle logging support James Smart
2015-12-17 8:14 ` Hannes Reinecke
2015-12-17 15:57 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672DB54.2090803@avagotech.com \
--to=james.smart@avagotech.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).