From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 14/15] be2iscsi: Fix WRB leak in login/logout path Date: Fri, 18 Dec 2015 10:08:16 +0100 Message-ID: <5673CD00.2070803@suse.de> References: <1450194906-12925-1-git-send-email-jitendra.bhivare@avagotech.com> <1450194906-12925-15-git-send-email-jitendra.bhivare@avagotech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx2.suse.de ([195.135.220.15]:39934 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966146AbbLRJIR (ORCPT ); Fri, 18 Dec 2015 04:08:17 -0500 In-Reply-To: <1450194906-12925-15-git-send-email-jitendra.bhivare@avagotech.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jitendra Bhivare , linux-scsi@vger.kernel.org, michaelc@cs.wisc.edu On 12/15/2015 04:55 PM, Jitendra Bhivare wrote: > From: Jitendra > > Login/Logout loop was hanging after few hours. /var/log/message showe= d > that alloc_wrb_handle() function was not able to allocate any new WRB= =2E > > Sep 11 11:25:22 Jhelum10 kernel: connection32513:0: Could not send no= pout > Sep 11 11:25:22 Jhelum10 kernel: scsi host10: BM_4989 : Alloc of WRB_= HANDLE > Failedfor the CID : 384 > Sep 11 11:25:22 Jhelum10 kernel: connection32513:0: Could not allocat= e pdu for > mgmt task. > > Driver allocates WRB to pass login negotiated parameters information = to FW > in beiscsi_offload_connection(). This allocated WRB was not freed so = there > was WRB_Leak happening. > > Put WRB used for posting the login-negotiated parameters back in pool= =2E > > Signed-off-by: Jitendra > --- > drivers/scsi/be2iscsi/be_main.c | 72 ++++++++++++++++++++++++++--= ---------- > 1 files changed, 49 insertions(+), 23 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html