From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH v3 57/77] ncr5380: Use standard list data structure Date: Tue, 22 Dec 2015 08:55:21 +0100 Message-ID: <567901E9.70006@suse.de> References: <20151222011737.980475848@telegraphics.com.au> <20151222011753.525503258@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151222011753.525503258@telegraphics.com.au> Sender: linux-m68k-owner@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" , Russell King , linux-arm-kernel@lists.infradead.org List-Id: linux-scsi@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > The NCR5380 drivers have a home-spun linked list implementation for > scsi_cmnd structs that uses cmd->host_scribble as a 'next' pointer. A= dopt > the standard list_head data structure and list operations instead. Re= move > the eh_abort_handler rather than convert it. Doing the conversion wou= ld > only be churn because the existing EH handlers don't work and get rep= laced > in a subsequent patch. > > Signed-off-by: Finn Thain > > --- > > Changed since v2: > - Fix NULL pointer dereference in NCR5380_reselect() when SUPPORT_TAG= S is > enabled in the atari_NCR5380.c core driver. > Well, using ->host_scribble allows for an easy check on the midlayer if= =20 a command has been properly released by the LLDD. But that's just a=20 side-note. Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)