Re: [PATCH 14/20] scsi_dh_alua: update all port states

[Hannes Reinecke <hare@suse.de>]

On 12/30/2015 02:23 PM, Christoph Hellwig wrote:
> On Tue, Dec 08, 2015 at 08:37:34AM +0100, Hannes Reinecke wrote:
>> When we read in the target port group state we should be
>> updating all affected port groups, otherwise we risk
>> running out of sync.
>
> Why would we ever have multiple alua_port_group structures for the
> same port that we'd need to iterate here?
>
That is the whole point :-)
The index into the port_group structure is the tuple
(LUN ID, group ID), where each tuple corresponds to a different/separate 
port group state.
So for each LUN ID we will have at least two port_group structures, the 
states of which will be returned per call to REPORT TARGET PORT GROUPS.
And as the other paths might be unavailable we might not be able to 
execute REPORT TARGET PORT GROUPS at all. So we need to update it here.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html