From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Akinobu Mita <akinobu.mita@gmail.com>,
Christoph Hellwig <hch@infradead.org>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
Yaniv Gardi <ygardi@codeaurora.org>,
Gilad Broner <gbroner@codeaurora.org>,
Subhash Jadavani <subhashj@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH] add driver for DesignWare UFS Host Controller
Date: Fri, 8 Jan 2016 15:51:22 +0000 [thread overview]
Message-ID: <568FDAFA.9020507@synopsys.com> (raw)
In-Reply-To: <CAC5umyg=vhQ_5Nz60u8gsZFEOFP45cmXnSGny-v4ddk4qNeMHA@mail.gmail.com>
Hi,
On 1/8/2016 2:20 PM, Akinobu Mita wrote:
> 2016-01-07 18:44 GMT+09:00 Christoph Hellwig <hch@infradead.org>:
>>> This driver patch includes a core driver and glue drivers for pci and platform
>>> for the DesignWare UFS Host IP.
>>
>> Why doesn't this use the existing ufs core? The architecture looks
>> completely backwards to me.
>
> I agree. The existing ufs driver can have variant specific operations
> (hba->vops) and also can define quirks. So if DesignWare UFS host
> controller requires vendor specific register settings or DME operations
> in initialization, or needs special workarounds for the specific versions,
> it can use those mechanisms and shares common parts between other host
> controllers.
>
I agree with you. We're already engaging internally a patch rework and so there
will be a new patch soon based on your comments.
Thank you for your comments.
Joao
next prev parent reply other threads:[~2016-01-08 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 17:27 [PATCH] add driver for DesignWare UFS Host Controller Joao Pinto
2016-01-07 9:44 ` Christoph Hellwig
2016-01-08 14:20 ` Akinobu Mita
2016-01-08 15:51 ` Joao Pinto [this message]
2016-01-13 18:41 ` Joao Pinto
2016-01-14 2:54 ` Akinobu Mita
2016-01-14 9:58 ` Joao Pinto
2016-01-27 17:04 ` Joao Pinto
2016-01-28 12:35 ` Akinobu Mita
2016-01-28 17:00 ` Joao Pinto
2016-01-28 18:07 ` Joao Pinto
2016-01-28 18:21 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568FDAFA.9020507@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=akinobu.mita@gmail.com \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=subhashj@codeaurora.org \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).