From: Hannes Reinecke <hare@suse.de>
To: Jitendra Bhivare <jitendra.bhivare@avagotech.com>,
linux-scsi@vger.kernel.org, michaelc@cs.wisc.edu
Subject: Re: [PATCH v4 03/17] be2iscsi: Fix to use atomic bit operations for tag_state
Date: Wed, 20 Jan 2016 11:13:50 +0100 [thread overview]
Message-ID: <569F5DDE.80900@suse.de> (raw)
In-Reply-To: <1453279261-659-4-git-send-email-jitendra.bhivare@avagotech.com>
On 01/20/2016 09:40 AM, Jitendra Bhivare wrote:
> beiscsi_mccq_compl sets MCC_TAG_STATE_TIMEOUT before setting up
> tag_mem_state. be_mcc_compl_process_isr checks for
> MCC_TAG_STATE_TIMEOUT first then accesses tag_mem_state which might be
> still getting populated in the process context.
>
> Fix:
> Set MCC_TAG_STATE_TIMEOUT after tag_mem_state is populated.
> Removed MCC_TAG_STATE_COMPLETED. When posted its in running state and
> the running state is cleared in be_mcc_compl_process_isr.
> be_mcc_notify now takes tag argument to set it to running state.
> Use bit operations for tag_state. Use barriers before setting the state.
>
> Signed-off-by: Jitendra Bhivare <jitendra.bhivare@avagotech.com>
> ---
> drivers/scsi/be2iscsi/be.h | 7 ++-
> drivers/scsi/be2iscsi/be_cmds.c | 111 ++++++++++++++++++++--------------------
> drivers/scsi/be2iscsi/be_cmds.h | 4 +-
> drivers/scsi/be2iscsi/be_mgmt.c | 39 ++++++++------
> 4 files changed, 84 insertions(+), 77 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-20 10:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 8:40 [PATCH v4 00/17] be2iscsi: driver update 11.0.0.0 Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 01/17] be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 02/17] be2iscsi: Fix mbox synchronization replacing spinlock with mutex Jitendra Bhivare
2016-01-20 10:11 ` Hannes Reinecke
2016-01-20 8:40 ` [PATCH v4 03/17] be2iscsi: Fix to use atomic bit operations for tag_state Jitendra Bhivare
2016-01-20 10:13 ` Hannes Reinecke [this message]
2016-01-20 8:40 ` [PATCH v4 04/17] be2iscsi: Fix to synchronize tag allocation using spin_lock Jitendra Bhivare
2016-01-20 10:14 ` Hannes Reinecke
2016-01-20 8:40 ` [PATCH v4 05/17] be2iscsi: Set mbox timeout to 30s Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 06/17] be2iscsi: Added return value check for mgmt_get_all_if_id Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 07/17] be2iscsi: Fix to remove shutdown entry point Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 08/17] be2iscsi: Fix VLAN support for IPv6 network Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 09/17] be2iscsi: Fix to handle misconfigured optics events Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 10/17] be2iscsi: Add FW config validation Jitendra Bhivare
2016-01-20 10:15 ` Hannes Reinecke
2016-01-20 8:40 ` [PATCH v4 11/17] be2iscsi: Fix return value for MCC completion Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 12/17] be2iscsi: Fix IOPOLL implementation Jitendra Bhivare
2016-01-20 8:40 ` [PATCH v4 13/17] scsi_transport_iscsi: Add 25G and 40G speed definition Jitendra Bhivare
2016-01-20 10:16 ` Hannes Reinecke
2016-01-20 8:40 ` [PATCH v4 14/17] be2iscsi: Fix to process 25G link speed info from FW Jitendra Bhivare
2016-01-20 10:16 ` Hannes Reinecke
2016-01-20 8:40 ` [PATCH v4 15/17] be2iscsi: Fix async link event processing Jitendra Bhivare
2016-01-20 10:17 ` Hannes Reinecke
2016-01-20 8:41 ` [PATCH v4 16/17] be2iscsi: Fix WRB leak in login/logout path Jitendra Bhivare
2016-01-20 8:41 ` [PATCH v4 17/17] be2iscsi: Update the driver version Jitendra Bhivare
2016-01-20 10:18 ` Hannes Reinecke
2016-01-27 1:45 ` [PATCH v4 00/17] be2iscsi: driver update 11.0.0.0 Martin K. Petersen
2016-01-27 8:19 ` Jitendra Bhivare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F5DDE.80900@suse.de \
--to=hare@suse.de \
--cc=jitendra.bhivare@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).