From: John Garry <john.garry@huawei.com>
To: Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org
Cc: user-mode-linux-devel@lists.sourceforge.net,
"James E.J. Bottomley" <JBottomley@odin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs
Date: Tue, 26 Jan 2016 10:54:58 +0000 [thread overview]
Message-ID: <56A75082.6050104@huawei.com> (raw)
In-Reply-To: <56A74AF6.90307@nod.at>
On 26/01/2016 10:31, Richard Weinberger wrote:
> Am 26.01.2016 um 11:15 schrieb John Garry:
>> On 25/01/2016 22:24, Richard Weinberger wrote:
>>> Not every arch has io or DMA memory.
>>> So, unbreak the build by fixing the dependencies.
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> drivers/scsi/hisi_sas/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
>>> index 37a0c71..f9157f4 100644
>>> --- a/drivers/scsi/hisi_sas/Kconfig
>>> +++ b/drivers/scsi/hisi_sas/Kconfig
>>> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS
>>> tristate "HiSilicon SAS"
>>> select SCSI_SAS_LIBSAS
>>> select BLK_DEV_INTEGRITY
>>> + depends on HAS_IOMEM && HAS_DMA
>>> help
>>> This driver supports HiSilicon's SAS HBA
>>>
>>
>> I think that there is already a fix for depencencies from Geert:
>> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes
>
> Hmm, right. But we still need HAS_IOMEM too.
>
> Thanks,
> //richard
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
We can just add HAS_IOMEM dependency on the scsi fixes branch, ok?
Cheers,
John
next prev parent reply other threads:[~2016-01-26 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1453760661-1444-1-git-send-email-richard@nod.at>
2016-01-25 22:24 ` [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger
2016-01-26 10:15 ` John Garry
2016-01-26 10:31 ` Richard Weinberger
2016-01-26 10:54 ` John Garry [this message]
2016-01-27 2:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A75082.6050104@huawei.com \
--to=john.garry@huawei.com \
--cc=JBottomley@odin.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).