* [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs
[not found] <1453760661-1444-1-git-send-email-richard@nod.at>
@ 2016-01-25 22:24 ` Richard Weinberger
2016-01-26 10:15 ` John Garry
0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2016-01-25 22:24 UTC (permalink / raw)
To: linux-kernel
Cc: John Garry, user-mode-linux-devel, Martin K. Petersen,
Richard Weinberger, James E.J. Bottomley, linux-scsi
Not every arch has io or DMA memory.
So, unbreak the build by fixing the dependencies.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/scsi/hisi_sas/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
index 37a0c71..f9157f4 100644
--- a/drivers/scsi/hisi_sas/Kconfig
+++ b/drivers/scsi/hisi_sas/Kconfig
@@ -2,5 +2,6 @@ config SCSI_HISI_SAS
tristate "HiSilicon SAS"
select SCSI_SAS_LIBSAS
select BLK_DEV_INTEGRITY
+ depends on HAS_IOMEM && HAS_DMA
help
This driver supports HiSilicon's SAS HBA
--
1.8.4.5
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs
2016-01-25 22:24 ` [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger
@ 2016-01-26 10:15 ` John Garry
2016-01-26 10:31 ` Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: John Garry @ 2016-01-26 10:15 UTC (permalink / raw)
To: Richard Weinberger, linux-kernel
Cc: user-mode-linux-devel, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, Geert Uytterhoeven
On 25/01/2016 22:24, Richard Weinberger wrote:
> Not every arch has io or DMA memory.
> So, unbreak the build by fixing the dependencies.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/scsi/hisi_sas/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
> index 37a0c71..f9157f4 100644
> --- a/drivers/scsi/hisi_sas/Kconfig
> +++ b/drivers/scsi/hisi_sas/Kconfig
> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS
> tristate "HiSilicon SAS"
> select SCSI_SAS_LIBSAS
> select BLK_DEV_INTEGRITY
> + depends on HAS_IOMEM && HAS_DMA
> help
> This driver supports HiSilicon's SAS HBA
>
I think that there is already a fix for depencencies from Geert:
http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes
Cheers,
John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs
2016-01-26 10:15 ` John Garry
@ 2016-01-26 10:31 ` Richard Weinberger
2016-01-26 10:54 ` John Garry
0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2016-01-26 10:31 UTC (permalink / raw)
To: John Garry, linux-kernel
Cc: user-mode-linux-devel, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, Geert Uytterhoeven
Am 26.01.2016 um 11:15 schrieb John Garry:
> On 25/01/2016 22:24, Richard Weinberger wrote:
>> Not every arch has io or DMA memory.
>> So, unbreak the build by fixing the dependencies.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/scsi/hisi_sas/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
>> index 37a0c71..f9157f4 100644
>> --- a/drivers/scsi/hisi_sas/Kconfig
>> +++ b/drivers/scsi/hisi_sas/Kconfig
>> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS
>> tristate "HiSilicon SAS"
>> select SCSI_SAS_LIBSAS
>> select BLK_DEV_INTEGRITY
>> + depends on HAS_IOMEM && HAS_DMA
>> help
>> This driver supports HiSilicon's SAS HBA
>>
>
> I think that there is already a fix for depencencies from Geert:
> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes
Hmm, right. But we still need HAS_IOMEM too.
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs
2016-01-26 10:31 ` Richard Weinberger
@ 2016-01-26 10:54 ` John Garry
2016-01-27 2:16 ` Martin K. Petersen
0 siblings, 1 reply; 5+ messages in thread
From: John Garry @ 2016-01-26 10:54 UTC (permalink / raw)
To: Richard Weinberger, linux-kernel
Cc: user-mode-linux-devel, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, Geert Uytterhoeven
On 26/01/2016 10:31, Richard Weinberger wrote:
> Am 26.01.2016 um 11:15 schrieb John Garry:
>> On 25/01/2016 22:24, Richard Weinberger wrote:
>>> Not every arch has io or DMA memory.
>>> So, unbreak the build by fixing the dependencies.
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> drivers/scsi/hisi_sas/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
>>> index 37a0c71..f9157f4 100644
>>> --- a/drivers/scsi/hisi_sas/Kconfig
>>> +++ b/drivers/scsi/hisi_sas/Kconfig
>>> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS
>>> tristate "HiSilicon SAS"
>>> select SCSI_SAS_LIBSAS
>>> select BLK_DEV_INTEGRITY
>>> + depends on HAS_IOMEM && HAS_DMA
>>> help
>>> This driver supports HiSilicon's SAS HBA
>>>
>>
>> I think that there is already a fix for depencencies from Geert:
>> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes
>
> Hmm, right. But we still need HAS_IOMEM too.
>
> Thanks,
> //richard
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
We can just add HAS_IOMEM dependency on the scsi fixes branch, ok?
Cheers,
John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs
2016-01-26 10:54 ` John Garry
@ 2016-01-27 2:16 ` Martin K. Petersen
0 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2016-01-27 2:16 UTC (permalink / raw)
To: John Garry
Cc: Richard Weinberger, linux-kernel, user-mode-linux-devel,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
Geert Uytterhoeven
>>>>> "John" == John Garry <john.garry@huawei.com> writes:
John> We can just add HAS_IOMEM dependency on the scsi fixes branch, ok?
Yes, please submit a patch against 4.5/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-27 2:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1453760661-1444-1-git-send-email-richard@nod.at>
2016-01-25 22:24 ` [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger
2016-01-26 10:15 ` John Garry
2016-01-26 10:31 ` Richard Weinberger
2016-01-26 10:54 ` John Garry
2016-01-27 2:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).