From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Garry Subject: Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Date: Tue, 26 Jan 2016 10:54:58 +0000 Message-ID: <56A75082.6050104@huawei.com> References: <1453760661-1444-1-git-send-email-richard@nod.at> <1453760661-1444-4-git-send-email-richard@nod.at> <56A74743.6000308@huawei.com> <56A74AF6.90307@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56A74AF6.90307@nod.at> Sender: linux-kernel-owner@vger.kernel.org To: Richard Weinberger , linux-kernel@vger.kernel.org Cc: user-mode-linux-devel@lists.sourceforge.net, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Geert Uytterhoeven List-Id: linux-scsi@vger.kernel.org On 26/01/2016 10:31, Richard Weinberger wrote: > Am 26.01.2016 um 11:15 schrieb John Garry: >> On 25/01/2016 22:24, Richard Weinberger wrote: >>> Not every arch has io or DMA memory. >>> So, unbreak the build by fixing the dependencies. >>> >>> Signed-off-by: Richard Weinberger >>> --- >>> drivers/scsi/hisi_sas/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig >>> index 37a0c71..f9157f4 100644 >>> --- a/drivers/scsi/hisi_sas/Kconfig >>> +++ b/drivers/scsi/hisi_sas/Kconfig >>> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS >>> tristate "HiSilicon SAS" >>> select SCSI_SAS_LIBSAS >>> select BLK_DEV_INTEGRITY >>> + depends on HAS_IOMEM && HAS_DMA >>> help >>> This driver supports HiSilicon's SAS HBA >>> >> >> I think that there is already a fix for depencencies from Geert: >> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes > > Hmm, right. But we still need HAS_IOMEM too. > > Thanks, > //richard > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > We can just add HAS_IOMEM dependency on the scsi fixes branch, ok? Cheers, John