From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Christoph Hellwig <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
linux-block@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional
Date: Mon, 8 Feb 2016 08:26:25 +0100 [thread overview]
Message-ID: <56B84321.3010308@suse.de> (raw)
In-Reply-To: <1454861040.2329.4.camel@HansenPartnership.com>
On 02/07/2016 05:04 PM, James Bottomley wrote:
> On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote:
>> Keith said it should be on by default, and I promised him to change
>> it once we run into problems, which I guess this counts as.
>>
>> But just curious: what distro are you using? Upstream systemd
>> explicitly rejected using scsi_id for NVMe here:
>>
>> https://github.com/systemd/systemd/issues/1453
>>
>> and all my test systems don't do this either.
>
> This was SUSE (in my case, openSUSE Leap). I just checked the source
> package; they patch the by-id rules back in for NVME:
>
> # PATCH-FIX-SUSE 1101-rules-persistent-device-names-for-NVMe-devices.patch (bsc#944132)
> Patch1101: 1101-rules-persistent-device-names-for-NVMe-devices.patch
>
> The bugzilla is giving access denied for bug id 944132, so it's likely
> some proprietary vendor problem. The patch has no preamble, so it's
> hard to tell what they were thinking.
>
They didn't think at all. That abovementioned bug just states 'by-id
symlinks for NVMe drives are missing'.
And they fixed it by add the respective rules (using sg_inq) to udev.
There's no mentioning of any NVMe specific sysfs attributes whatsoever.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-02-08 7:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 18:33 complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional James Bottomley
2016-02-07 9:22 ` Christoph Hellwig
2016-02-07 16:04 ` James Bottomley
2016-02-07 22:28 ` Jens Axboe
2016-02-07 23:07 ` James Bottomley
2016-02-08 7:24 ` Christoph Hellwig
2016-02-08 7:32 ` Hannes Reinecke
2016-02-08 10:01 ` Sagi Grimberg
2016-02-08 10:13 ` Christoph Hellwig
2016-02-08 15:12 ` Keith Busch
2016-02-08 15:19 ` Hannes Reinecke
2016-02-08 16:15 ` Keith Busch
2016-02-08 15:23 ` James Bottomley
2016-02-09 12:50 ` Christoph Hellwig
2016-02-09 13:29 ` Jens Axboe
2016-02-09 17:12 ` Christoph Hellwig
2016-02-09 17:14 ` Jens Axboe
2016-02-09 17:19 ` Christoph Hellwig
2016-02-09 17:19 ` Jens Axboe
2016-02-09 15:37 ` James Bottomley
2016-02-08 7:26 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B84321.3010308@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).