From: "Shi, Yang" <yang.shi@linaro.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: JBottomley@odin.com, martin.petersen@oracle.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] scsi: fdomain: add missing CONFIG_ to PCMCIA
Date: Tue, 9 Feb 2016 15:28:31 -0800 [thread overview]
Message-ID: <56BA761F.4000305@linaro.org> (raw)
In-Reply-To: <20160209232510.0c38ff77@lxorguk.ukuu.org.uk>
On 2/9/2016 3:25 PM, One Thousand Gnomes wrote:
> On Tue, 9 Feb 2016 14:16:49 -0800
> Yang Shi <yang.shi@linaro.org> wrote:
>
>> There are some "#ifdef PCMCIA" in the driver code, but all of them missed
>> CONFIG_ prefix. Correct PCMCIA to CONFIG_PCMCIA.
>>
>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
>
> NAK. This breaks the driver completely
>
>
> Read drivers/scsi/pcmcia/fdomain*
Got it. Thanks for spotting out this. Sorry for the unthought change.
Yang
>
> Alan
>
prev parent reply other threads:[~2016-02-09 23:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 22:16 [PATCH] scsi: fdomain: add missing CONFIG_ to PCMCIA Yang Shi
2016-02-09 23:25 ` One Thousand Gnomes
2016-02-09 23:28 ` Shi, Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA761F.4000305@linaro.org \
--to=yang.shi@linaro.org \
--cc=JBottomley@odin.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).