Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Tomas Henzl <thenzl@redhat.com>
To: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	JBottomley@Parallels.com, jejb@kernel.org, hch@infradead.org
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	Sathya.Prakash@broadcom.com, kashyap.desai@broadcom.com,
	krishnaraddi.mankani@broadcom.com, linux-kernel@vger.kernel.org,
	chaitra.basappa@broadcom.com, sreekanth.reddy@broadcom.com,
	Suganath prabu Subramani <suganath-prabu.subramani@avagotech.com>
Subject: Re: [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.
Date: Thu, 18 Feb 2016 13:54:02 +0100	[thread overview]
Message-ID: <56C5BEEA.7030004@redhat.com> (raw)
In-Reply-To: <1455784786-19086-1-git-send-email-suganath-prabu.subramani@broadcom.com>

On 18.2.2016 09:39, Suganath Prabu Subramani wrote:
> From: Suganath prabu Subramani <suganath-prabu.subramani@avagotech.com>
>
> Deallocate resources before reallocating of the same in retry_allocation
> path of _base_allocate_memory_pools()
>
> Signed-off-by: Suganath prabu Subramani <suganath-prabu.subramani@avagotech.com>
> Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com>
> ---
>  drivers/scsi/mpt3sas/mpt3sas_base.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index afdb13a..5bbbbf2 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -3414,6 +3414,7 @@ _base_allocate_memory_pools(struct MPT3SAS_ADAPTER *ioc,  int sleep_flag)
>  			goto out;
>  		retry_sz = 64;
>  		ioc->hba_queue_depth -= retry_sz;
> +		_base_release_memory_pools(ioc);
>  		goto retry_allocation;
>  	}
>  

Reviewed-by: Tomas Henzl <thenzl@redhat.com>


  parent reply	other threads:[~2016-02-18 12:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18  8:39 [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value Suganath Prabu Subramani
2016-02-18  8:39 ` [PATCH v2 2/2] Updating maintainers list for MPT FUSION DRIVERS Suganath Prabu Subramani
2016-02-18 12:54 ` Tomas Henzl [this message]
2016-02-18 13:10   ` [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value Johannes Thumshirn
2016-02-23 22:38 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C5BEEA.7030004@redhat.com \
    --to=thenzl@redhat.com \
    --cc=JBottomley@Parallels.com \
    --cc=Sathya.Prakash@broadcom.com \
    --cc=chaitra.basappa@broadcom.com \
    --cc=hch@infradead.org \
    --cc=jejb@kernel.org \
    --cc=kashyap.desai@broadcom.com \
    --cc=krishnaraddi.mankani@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@avagotech.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox