From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCHv7 20/23] scsi: Add 'access_state' attribute
Date: Fri, 19 Feb 2016 07:50:28 +0100 [thread overview]
Message-ID: <56C6BB34.8070000@suse.de> (raw)
In-Reply-To: <56C64059.8060604@sandisk.com>
On 02/18/2016 11:06 PM, Bart Van Assche wrote:
> On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
>> --- a/include/scsi/scsi_proto.h
>> +++ b/include/scsi/scsi_proto.h
>> @@ -277,5 +277,17 @@ struct scsi_lun {
>> __u8 scsi_lun[8];
>> };
>>
>> +/* SPC asymmetric access states */
>> +#define SCSI_ACCESS_STATE_OPTIMAL 0x00
>> +#define SCSI_ACCESS_STATE_ACTIVE 0x01
>> +#define SCSI_ACCESS_STATE_STANDBY 0x02
>> +#define SCSI_ACCESS_STATE_UNAVAILABLE 0x03
>> +#define SCSI_ACCESS_STATE_LBA 0x04
>> +#define SCSI_ACCESS_STATE_OFFLINE 0x0e
>> +#define SCSI_ACCESS_STATE_TRANSITIONING 0x0f
>> +
>> +#define SCSI_ACCESS_STATE_MASK 0x0f
>> +#define SCSI_ACCESS_STATE_PREFERRED 0x80
>> +#define SCSI_ACCESS_STATE_UNKNOWN 0x70
>
> Please mention in the comment above these constants that the ALUA
> state values apply to both the RTPG and STPG commands but that the
> PREFERRED bit only applies to the RTPG command.
>
> All constants in scsi_proto.h come from a SCSI standard. However,
> this patch adds a constant that does not come from a SCSI standard
> (SCSI_ACCESS_STATE_UNKNOWN). Please remove this constant entirely
> because it causes confusion. sdev_show_access_state() only
> interprets the PREFERRED bit and the lower 4 bits of the
> access_state member variable. This means that the
> SCSI_ACCESS_STATE_UNKNOWN entry in sdev_access_states[] is never
> used and hence should be left out. This also means that the
> "sdev->access_state = SCSI_ACCESS_STATE_UNKNOWN" assignment in
> scsi_scan.c is equivalent to "sdev->access_state =
> SCSI_ACCESS_STATE_OPTIMAL".
>
Correct. Will be fixing it up.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-19 6:50 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 8:24 [PATCHv7 00/23] ALUA device handler update, part II Hannes Reinecke
2016-02-15 8:24 ` [PATCHv7 01/23] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2016-02-15 8:24 ` [PATCHv7 02/23] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2016-02-18 18:22 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 03/23] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2016-02-18 19:25 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 04/23] scsi_dh_alua: call alua_rtpg() if stpg fails Hannes Reinecke
2016-02-18 18:24 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 05/23] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2016-02-18 19:31 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 06/23] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2016-02-15 8:24 ` [PATCHv7 07/23] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2016-02-18 19:41 ` Bart Van Assche
2016-02-19 6:42 ` Hannes Reinecke
2016-02-15 8:24 ` [PATCHv7 08/23] scsi_dh_alua: use unique device id Hannes Reinecke
2016-02-18 19:44 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 09/23] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2016-02-18 19:48 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 10/23] revert commit a8e5a2d593cb ("[SCSI] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning") Hannes Reinecke
2016-02-18 19:48 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 11/23] scsi_dh_alua: move optimize_stpg evaluation Hannes Reinecke
2016-02-18 19:49 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 12/23] scsi_dh_alua: remove 'rel_port' from alua_dh_data structure Hannes Reinecke
2016-02-18 19:50 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 13/23] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2016-02-18 21:12 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 14/23] scsi_dh_alua: Allow workqueue to run synchronously Hannes Reinecke
2016-02-18 21:13 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 15/23] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA' Hannes Reinecke
2016-02-18 21:14 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 16/23] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2016-02-18 21:16 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 17/23] scsi_dh_alua: update all port states Hannes Reinecke
2016-02-18 21:38 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 18/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2016-02-18 21:48 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 19/23] scsi_dh: add 'rescan' callback Hannes Reinecke
2016-02-18 21:49 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 20/23] scsi: Add 'access_state' attribute Hannes Reinecke
2016-02-18 21:55 ` Bart Van Assche
2016-02-19 6:49 ` Hannes Reinecke
2016-02-18 22:06 ` Bart Van Assche
2016-02-19 6:50 ` Hannes Reinecke [this message]
2016-02-15 8:24 ` [PATCHv7 21/23] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-02-18 22:08 ` Bart Van Assche
2016-02-19 6:50 ` Hannes Reinecke
2016-02-15 8:24 ` [PATCHv7 22/23] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-02-18 22:12 ` Bart Van Assche
2016-02-15 8:24 ` [PATCHv7 23/23] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C6BB34.8070000@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).