From: Lee Duncan <lduncan@suse.com>
To: Konrad Rzeszutek Wilk <konrad@kernel.org>,
Mike Christie <michaelc@cs.wisc.edu>
Cc: linux-scsi@vger.kernel.org, hare@suse.de
Subject: Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask
Date: Mon, 29 Feb 2016 13:49:19 -0800 [thread overview]
Message-ID: <56D4BCDF.7000001@suse.com> (raw)
In-Reply-To: <CACJDEmr6FRHGNGtSRFt=v-ufS0NEs6M_qs-bmssytDsH+-fESA@mail.gmail.com>
On 02/29/2016 01:04 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 29, 2016 at 1:45 PM, Mike Christie <michaelc@cs.wisc.edu> wrote:
>> On 02/25/2016 12:15 PM, Lee Duncan wrote:
>>> From: Hannes Reinecke <hare@suse.de>
>>>
>>> The iBFT table only specifies a prefix length, not a netmask.
>>> And the netmask is pretty much pointless for IPv6.
>>> So introduce a new attribute 'prefix-len' and display the
>>> netmask attribute only for IPv4 addresses.
>>
>> The code looks ok to me, but I think this ipv4 comment was left over
>> from the last posting since it conflicts with the comment below about
>> always displaying it. Maybe it can just be edited when the patch is
>> merged to avoid having to resend again. If so,
>>
>> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
>>
>
> Cool. Let me roll it up and send the git pull to Linus.
I actually just resent it, but the only change was to truncate the last
line of first paragraph of the comment to:
So introduce a new attribute 'prefix-len'.
>
> This does not seem be super-urgent so it can wait for the upcoming merge window?
>
>>
>>>
>>> Some older user-space code might rely on the netmask attribute
>>> being present, so we should always display it.
>>>
>>> Changes from v1:
>>> - Combined two patches into one
>>>
>>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>>> Signed-off-by: Lee Duncan <lduncan@suse.com>
>
--
Lee Duncan
SUSE Labs
next prev parent reply other threads:[~2016-02-29 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 18:15 [PATCHv2] Enable iBFT IPv6 booting with prefix length Lee Duncan
2016-02-25 18:15 ` [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask Lee Duncan
2016-02-29 18:45 ` Mike Christie
2016-02-29 21:04 ` Konrad Rzeszutek Wilk
2016-02-29 21:49 ` Lee Duncan [this message]
2016-02-29 21:25 ` Lee Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4BCDF.7000001@suse.com \
--to=lduncan@suse.com \
--cc=hare@suse.de \
--cc=konrad@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).