From: Hannes Reinecke <hare@suse.de>
To: "Seymour, Shane M" <shane.seymour@hpe.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Ewan Milne <emilne@redhat.com>,
Bart van Assche <bart.vanassche@sandisk.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/6] scsi: Add 'access_state' and 'preferred_path' attribute
Date: Tue, 1 Mar 2016 16:01:25 +0800 [thread overview]
Message-ID: <56D54C55.8040101@suse.de> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB4453A465@G4W3219.americas.hpqcorp.net>
On 03/01/2016 03:08 PM, Seymour, Shane M wrote:
> in https://www.kernel.org/doc/Documentation/filesystems/sysfs.txt
>
> it says:
>
> - show() must not use snprintf() when formatting the value to be
> returned to user space. If you can guarantee that an overflow
> will never happen you can use sprintf() otherwise you must use
> scnprintf().
>
So? I _do_ know the length of the strings I'm going to write into the
buffer, so there cannot possibly be an overflow.
Unless I've made an error during calculation of the string length, of
course. But both functions can only return fixed length strings, so I'm
safe here.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-01 8:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 4:55 [PATCH 0/6] SCSI 'access_state' attribute Hannes Reinecke
2016-03-01 4:55 ` [PATCH 1/6] scsi: Add 'access_state' and 'preferred_path' attribute Hannes Reinecke
2016-03-01 7:08 ` Seymour, Shane M
2016-03-01 8:01 ` Hannes Reinecke [this message]
2016-03-01 13:06 ` Christoph Hellwig
2016-03-01 20:54 ` Bart Van Assche
2016-03-01 4:55 ` [PATCH 2/6] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-03-01 18:47 ` Bart Van Assche
2016-03-01 4:55 ` [PATCH 3/6] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-03-01 4:55 ` [PATCH 4/6] scsi_dh_rdac: " Hannes Reinecke
2016-03-01 13:08 ` Christoph Hellwig
2016-03-01 4:55 ` [PATCH 5/6] scsi_dh_emc: " Hannes Reinecke
2016-03-01 13:08 ` Christoph Hellwig
2016-03-01 4:55 ` [PATCH 6/6] scsi_sysfs: call 'device_add' after attaching device handler Hannes Reinecke
2016-03-01 13:07 ` Christoph Hellwig
2016-03-01 18:51 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D54C55.8040101@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shane.seymour@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).