From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, ben@decadent.org.uk,
Karen Xie <kxie@chelsio.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH net-next v3 4/4] ethtool.h: define INT_MAX for userland
Date: Fri, 4 Mar 2016 14:10:12 +0100 [thread overview]
Message-ID: <56D98934.4050409@cumulusnetworks.com> (raw)
In-Reply-To: <1457088739-1065-5-git-send-email-nicolas.dichtel@6wind.com>
On 03/04/2016 11:52 AM, Nicolas Dichtel wrote:
> INT_MAX needs limits.h in userland.
> When ethtool.h is included by a userland app, we got the following error:
>
> .../usr/include/linux/ethtool.h: In function 'ethtool_validate_speed':
> .../usr/include/linux/ethtool.h:1471:18: error: 'INT_MAX' undeclared (first use in this function)
> return speed <= INT_MAX || speed == SPEED_UNKNOWN
> ^
>
> Fixes: e02564ee334a ("ethtool: make validate_speed accept all speeds between 0 and INT_MAX")
> CC: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> include/uapi/linux/ethtool.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
Thanks!
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
next prev parent reply other threads:[~2016-03-04 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160303.170804.2300821465150459193.davem@davemloft.net>
2016-03-04 10:52 ` [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 1/4] uapi: define DIV_ROUND_UP for userland Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 2/4] cxgb4i: don't redefine DIV_ROUND_UP Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP Nicolas Dichtel
2016-03-04 21:36 ` Emil Velikov
2016-03-04 10:52 ` [PATCH net-next v3 4/4] ethtool.h: define INT_MAX for userland Nicolas Dichtel
2016-03-04 13:10 ` Nikolay Aleksandrov [this message]
2016-03-04 21:10 ` [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D98934.4050409@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=airlied@linux.ie \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=kxie@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox