public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Hannes Reinecke <hare@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Ewan Milne <emilne@redhat.com>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCHv2 6/6] scsi_sysfs: call 'device_add' after attaching device handler
Date: Fri, 4 Mar 2016 09:34:54 -0800	[thread overview]
Message-ID: <56D9C73E.7020703@sandisk.com> (raw)
In-Reply-To: <1456988052-78791-7-git-send-email-hare@suse.de>

On 03/02/2016 10:54 PM, Hannes Reinecke wrote:
> 'device_add' will be evaluating the 'is_visible' callback
> when creating the sysfs attributes. As by this time the
> device handler has not been attached the 'access_state'
> attribute will never be visible.
>
> This patch moves the code around so that the device handler
> is present by the time 'is_visible' is evaluated to
> correctly display the 'access_state' attribute.

Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com>

  parent reply	other threads:[~2016-03-04 17:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  6:54 [PATCHv2 0/6] SCSI 'access_state' attribute Hannes Reinecke
2016-03-03  6:54 ` [PATCHv2 1/6] scsi: Add 'access_state' and 'preferred_path' attribute Hannes Reinecke
2016-03-03  8:50   ` Johannes Thumshirn
2016-03-03 22:45   ` Bart Van Assche
2016-03-03  6:54 ` [PATCHv2 2/6] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-03-03  8:50   ` Johannes Thumshirn
2016-03-03  6:54 ` [PATCHv2 3/6] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-03-03  8:50   ` Johannes Thumshirn
2016-03-03  6:54 ` [PATCHv2 4/6] scsi_dh_rdac: " Hannes Reinecke
2016-03-03  8:55   ` Johannes Thumshirn
2016-03-03  6:54 ` [PATCHv2 5/6] scsi_dh_emc: " Hannes Reinecke
2016-03-03  8:56   ` Johannes Thumshirn
2016-03-03  6:54 ` [PATCHv2 6/6] scsi_sysfs: call 'device_add' after attaching device handler Hannes Reinecke
2016-03-03  8:56   ` Johannes Thumshirn
2016-03-04 17:34   ` Bart Van Assche [this message]
2016-03-05 22:22 ` [PATCHv2 0/6] SCSI 'access_state' attribute Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D9C73E.7020703@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox