Re: [PATCH] Avoid that long log lines are truncated

[Hannes Reinecke <hare@suse.de>]

On 03/14/2016 03:38 PM, Ewan Milne wrote:
> On Mon, 2016-03-14 at 07:19 -0700, Bart Van Assche wrote:
>> While testing the latest version of the SRP initiator and target
>> drivers I encountered the following message in the kernel log:
>>
>> sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
>>
>> This is a truncated message. Avoid that such truncation happens
>> by increasing the SCSI_LOG_BUFSIZE constant.
>>
>> Fixes: ded85c193a39 (scsi: Implement per-cpu logging buffer)
>> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
>> Cc: Hannes Reinecke <hare@suse.de>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Robert Elliott <elliott@hp.com>
>> Cc: Ewan D. Milne <emilne@redhat.com>
>> Cc: <stable@vger.kernel.org> # v4.0+
>> ---
>>  include/scsi/scsi_dbg.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/scsi/scsi_dbg.h b/include/scsi/scsi_dbg.h
>> index 56710e0..05d36eb 100644
>> --- a/include/scsi/scsi_dbg.h
>> +++ b/include/scsi/scsi_dbg.h
>> @@ -5,7 +5,7 @@ struct scsi_cmnd;
>>  struct scsi_device;
>>  struct scsi_sense_hdr;
>>  
>> -#define SCSI_LOG_BUFSIZE 128
>> +#define SCSI_LOG_BUFSIZE 256
>>  
>>  extern void scsi_print_command(struct scsi_cmnd *);
>>  extern size_t __scsi_format_command(char *, size_t,
> 
> Hmm.  Perhaps we should make the message less verbose instead?
> It looks like if we increase SCSI_LOG_BUFSIZE then we get fewer
> per-message buffers unless we also increase SCSI_LOG_SPOOLSIZE.
> 
Or just shorten the message itself.
It's really annoying having these really long messages showing up in
the system log ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html