From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: disable automatic target scan
Date: Tue, 15 Mar 2016 07:47:34 +0100 [thread overview]
Message-ID: <56E7B006.6020809@suse.de> (raw)
In-Reply-To: <yq1y49kfwa9.fsf@sermon.lab.mkp.net>
On 03/15/2016 12:57 AM, Martin K. Petersen wrote:
>>>>>> "Hannes" == Hannes Reinecke <hare@suse.de> writes:
>
>> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
>> index 97074c9..929204b 100644
>> --- a/drivers/scsi/scsi_scan.c
>> +++ b/drivers/scsi/scsi_scan.c
>> @@ -96,10 +96,11 @@ MODULE_PARM_DESC(max_luns,
>> #define SCSI_SCAN_TYPE_DEFAULT "sync"
>> #endif
>>
>> -char scsi_scan_type[6] = SCSI_SCAN_TYPE_DEFAULT;
>> +char scsi_scan_type[9] = SCSI_SCAN_TYPE_DEFAULT;
>>
>> -module_param_string(scan, scsi_scan_type, sizeof(scsi_scan_type), S_IRUGO);
>> -MODULE_PARM_DESC(scan, "sync, async or none");
>> +module_param_string(scan, scsi_scan_type, sizeof(scsi_scan_type),
>> + S_IRUGO|S_IWUSR);
>> +MODULE_PARM_DESC(scan, "sync, async, disabled, or none");
>
> So "disabled" is "sometimes enabled" and "none" is "really disabled"?
>
'disabled' means:
disable automatic scanning, but allow manual scanning via the 'scan'
attribute.
>> static unsigned int scsi_inq_timeout = SCSI_TIMEOUT/HZ + 18;
>>
>> @@ -1604,7 +1605,9 @@ static void __scsi_scan_target(struct device *parent, unsigned int channel,
>> * @channel: channel to scan
>> * @id: target id to scan
>> * @lun: Specific LUN to scan or SCAN_WILD_CARD
>> - * @rescan: passed to LUN scanning routines
>> + * @rescan: passed to LUN scanning routines; 0 for no rescan, 1 to rescan
>> + * existing LUNs, and 2 to override any 'scan_disabled' setting
>> + * from the host.
>
> enum SCSI_SCAN_FOO_BAR instead of magic values, please.
>
Okay.
> What's this "scan_disabled" setting from the host?
>
It's called a 'typo' and found quite frequently in the wilds :-)
I'll be sending a respin.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-15 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 15:33 [PATCH] scsi: disable automatic target scan Hannes Reinecke
2016-03-14 8:08 ` Johannes Thumshirn
2016-03-14 23:57 ` Martin K. Petersen
2016-03-15 6:47 ` Hannes Reinecke [this message]
2016-03-15 6:48 ` Christoph Hellwig
2016-03-15 6:53 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7B006.6020809@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).