From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Quinn Tran <quinn.tran@qlogic.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Cc: James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Himanshu Madhani <himanshu.madhani@qlogic.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi <linux-scsi@vger.kernel.org>,
"linux-scsi-owner@vger.kernel.org"
<linux-scsi-owner@vger.kernel.org>
Subject: Re: [PATCH 2/3] qla2xxx: Remove set-but-not-used variables
Date: Thu, 31 Mar 2016 08:57:26 -0700 [thread overview]
Message-ID: <56FD48E6.2050109@sandisk.com> (raw)
In-Reply-To: <10CF97DD-4A2C-45A7-9A20-6FA66479C17F@qlogic.com>
On 03/31/16 08:24, Quinn Tran wrote:
>>> diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
>>> b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
>>> index c1461d2..97fcbf2 100644
>>> --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
>>> +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
>>> @@ -311,13 +311,6 @@ static void tcm_qla2xxx_free_cmd(struct
>>> qla_tgt_cmd *cmd)
>>> */
>>> static int tcm_qla2xxx_check_stop_free(struct se_cmd *se_cmd)
>>> {
>>> - struct qla_tgt_cmd *cmd;
>>> -
>>> - if ((se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB) == 0) {
>>> - cmd = container_of(se_cmd, struct qla_tgt_cmd, se_cmd);
>>> - cmd->cmd_flags |= BIT_14;
>>> - }
>>> -
>>> return target_put_sess_cmd(se_cmd);
>>> }
>>
>> Apart from the qla24xx_els_dcmd_iocb() thingy (which has nothing to do
>> with your patch)
>> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
> QT: We use the cmd_flags portion for debugging crashes. It’s our form of tracing. Please do not delete. Thanks.
Hello Quinn,
OK, I will restore that code.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-31 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 23:24 [PATCH 0/3] qla2xxx: Patches for kernel v4.7 Bart Van Assche
2016-03-30 23:25 ` [PATCH 1/3] qla2xxx: Indicate out-of-memory with -ENOMEM Bart Van Assche
2016-03-31 7:30 ` Johannes Thumshirn
2016-03-31 15:21 ` Quinn Tran
2016-04-01 0:37 ` Martin K. Petersen
2016-03-30 23:25 ` [PATCH 2/3] qla2xxx: Remove set-but-not-used variables Bart Van Assche
2016-03-31 7:37 ` Johannes Thumshirn
2016-03-31 15:24 ` Quinn Tran
2016-03-31 15:57 ` Bart Van Assche [this message]
2016-03-30 23:26 ` [PATCH 3/3] qla2xxx: Assign names to the flags in cmd_flags Bart Van Assche
2016-03-31 7:56 ` Johannes Thumshirn
2016-03-31 15:16 ` Quinn Tran
2016-03-31 15:22 ` Bart Van Assche
2016-03-31 15:26 ` Quinn Tran
2016-03-31 15:52 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD48E6.2050109@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=himanshu.madhani@qlogic.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quinn.tran@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).