From: Krzysztof Kozlowski <krzk@kernel.org>
To: Josh Law <objecting@objecting.org>,
Manivannan Sadhasivam <mani@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: qcom: stop ignoring hibern8 exit failures
Date: Mon, 30 Mar 2026 09:46:44 +0200 [thread overview]
Message-ID: <56b8460c-228c-4775-8359-e80735b2ba22@kernel.org> (raw)
In-Reply-To: <20260329183514.133412-1-objecting@objecting.org>
On 29/03/2026 20:35, Josh Law wrote:
> Right now, we're blindly returning success even if waking the link fails during clock scaling. This is a mess because the core then tries to send SCSI commands to a dead link, causing huge timeouts.
>
> Just return the actual error so the core can catch the failure and roll back properly.
NAK, you were asked way too many times for the same and you just ignore
people's feedback.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-03-30 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 18:35 [PATCH] scsi: ufs: qcom: stop ignoring hibern8 exit failures Josh Law
2026-03-30 7:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b8460c-228c-4775-8359-e80735b2ba22@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=objecting@objecting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox