Re: [PATCH v1 1/2] scsi: ufs: add required delay after gating reference clock

Stanley Chu
2020-02-17T13:12:59Z

Hi Can,

> > } else if (!on && clki->enabled) {
> > clk_disable_unprepare(clki->clk);
> > + wait_us = hba->dev_info.clk_gating_wait_us;
> > + if (ref_clk && wait_us)
> > + usleep_range(wait_us, wait_us + 10);
>
> Hi Stanley,
>
> If wait_us is 1us, it would be inappropriate to use usleep_range() here.
> You have checks of the delay in patch #2, but why it is not needed here?
>
> Thanks,
> Can Guo.

You are right. I could make that delay checking as common function so it
can be used here as well to cover all possible values.

Thanks for suggestion.
Stanley