From: Hannes Reinecke <hare@suse.de>
To: Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com
Cc: jmoyer@redhat.com, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org, j-nomura@ce.jp.nec.com,
sagig@dev.mellanox.co.il
Subject: Re: [RFC PATCH 3/4] dm mpath: move trigger_event member to the end of 'struct multipath'
Date: Thu, 7 Apr 2016 17:03:06 +0200 [thread overview]
Message-ID: <570676AA.7040204@suse.de> (raw)
In-Reply-To: <1459454666-76428-4-git-send-email-snitzer@redhat.com>
On 03/31/2016 10:04 PM, Mike Snitzer wrote:
> Allows the 'work_mutex' member to no longer cross a cacheline.
>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> ---
> drivers/md/dm-mpath.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index 780e5d0..54daf96 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -89,8 +89,6 @@ struct multipath {
> atomic_t pg_init_in_progress; /* Only one pg_init allowed at once */
> atomic_t pg_init_count; /* Number of times pg_init called */
>
> - struct work_struct trigger_event;
> -
> /*
> * We must use a mempool of dm_mpath_io structs so that we
> * can resubmit bios on error.
> @@ -98,6 +96,7 @@ struct multipath {
> mempool_t *mpio_pool;
>
> struct mutex work_mutex;
> + struct work_struct trigger_event;
> };
>
> /*
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-07 15:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 20:04 [RFC PATCH 0/4] dm mpath: vastly improve blk-mq IO performance Mike Snitzer
2016-03-31 20:04 ` [RFC PATCH 1/4] dm mpath: switch to using bitops for state flags Mike Snitzer
2016-04-01 8:46 ` [dm-devel] " Johannes Thumshirn
2016-04-07 14:59 ` Hannes Reinecke
2016-03-31 20:04 ` [RFC PATCH 2/4] dm mpath: use atomic_t for counting members of 'struct multipath' Mike Snitzer
2016-04-01 8:48 ` [dm-devel] " Johannes Thumshirn
2016-04-07 15:02 ` Hannes Reinecke
2016-03-31 20:04 ` [RFC PATCH 3/4] dm mpath: move trigger_event member to the end " Mike Snitzer
2016-04-01 8:50 ` [dm-devel] " Johannes Thumshirn
2016-04-07 15:03 ` Hannes Reinecke [this message]
2016-03-31 20:04 ` [RFC PATCH 4/4] dm mpath: eliminate use of spinlock in IO fast-paths Mike Snitzer
2016-04-01 9:02 ` [dm-devel] " Johannes Thumshirn
2016-04-07 15:03 ` Hannes Reinecke
2016-04-01 8:12 ` [dm-devel] [RFC PATCH 0/4] dm mpath: vastly improve blk-mq IO performance Johannes Thumshirn
2016-04-01 13:22 ` Mike Snitzer
2016-04-01 13:37 ` Johannes Thumshirn
2016-04-01 14:14 ` Mike Snitzer
2016-04-07 14:58 ` Hannes Reinecke
2016-04-07 15:34 ` Mike Snitzer
2016-04-08 11:42 ` [dm-devel] " Johannes Thumshirn
2016-04-08 19:29 ` Mike Snitzer
2016-04-13 7:03 ` [dm-devel] " Johannes Thumshirn
2016-05-09 15:48 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570676AA.7040204@suse.de \
--to=hare@suse.de \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sagig@dev.mellanox.co.il \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).