linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Subject: Re: libiscsi: Use scsi helper to set information descriptor
Date: Wed, 13 Apr 2016 17:53:08 +0300	[thread overview]
Message-ID: <570E5D54.8070303@grimberg.me> (raw)
In-Reply-To: <20160413131425.GA9719@mwanda>

Hey Dan,

> Hello Sagi Grimberg,
>
> The patch a73c2a2f9123: "libiscsi: Use scsi helper to set information
> descriptor" from Jul 15, 2015, leads to the following static checker
> warning:
>
> 	drivers/scsi/libiscsi.c:858 iscsi_scsi_cmd_rsp()
> 	error: XXX uninitialized symbol 'sector'.
>
> drivers/scsi/libiscsi.c
>     850                  ascq = session->tt->check_protection(task, &sector);
>
> If "ascq" is 0x1 then there sector might not be initialized.  The
> documentation is not clear on how that works.  Har dee har har.  The
> oldest jokes are still the best...  :P

iscsi transports that implement this callout are expected
to set the sector which is passed by reference.

would it make the checker happy if we set sector to 0 before
calling check_protection (although it's not needed by no means)?

  reply	other threads:[~2016-04-13 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 13:14 libiscsi: Use scsi helper to set information descriptor Dan Carpenter
2016-04-13 14:53 ` Sagi Grimberg [this message]
2016-04-13 16:30   ` Dan Carpenter
2016-05-04 11:45     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570E5D54.8070303@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).